Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix partytown README #7001

Merged
merged 2 commits into from
May 5, 2023
Merged

Fix partytown README #7001

merged 2 commits into from
May 5, 2023

Conversation

Waxer59
Copy link
Contributor

@Waxer59 Waxer59 commented May 5, 2023

Changes

Fixed a code example that was wrongly closed in partytown readme.

  • BEFORE:
export default defineConfig({
  integrations: [partytown({
    // Example: Disable debug mode.
    config: { debug: false },

})
  • AFTER:
export default defineConfig({
  integrations: [partytown({
    // Example: Disable debug mode.
    config: { debug: false },
  })]
})

Testing

As only one block of code has been closed, no tests are required.

Docs

Within the partytown README there was a block that was not closed correctly, the example has been closed and corrected.

/cc @withastro/maintainers-docs for feedback!

@Waxer59 Waxer59 requested a review from a team as a code owner May 5, 2023 01:03
@changeset-bot
Copy link

changeset-bot bot commented May 5, 2023

🦋 Changeset detected

Latest commit: 6349506

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label May 5, 2023
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and fixing this @Waxer59 🙌

@delucis delucis merged commit ad5c754 into withastro:main May 5, 2023
2 checks passed
@astrobot-houston astrobot-houston mentioned this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants