Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export ChangeFreqEnum type for sitemap integration #7028

Merged
merged 4 commits into from May 25, 2023
Merged

Export ChangeFreqEnum type for sitemap integration #7028

merged 4 commits into from May 25, 2023

Conversation

alexanderniebuhr
Copy link
Member

Changes

add export for EnumType EnumChangefreq of sitemap integration

references:
https://discord.com/channels/830184174198718474/1104847738643947630
microsoft/TypeScript#53304
ekalinin/sitemap.js#224

Docs

Don't think it will break or affect users. But question: should a paragraph be added?
/cc @withastro/maintainers-docs for feedback!

@changeset-bot
Copy link

changeset-bot bot commented May 7, 2023

🦋 Changeset detected

Latest commit: a5476d2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label May 7, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fair to me. If I may be extra picky, naming as ChangeFreqEnum would be more consistent.

@alexanderniebuhr
Copy link
Member Author

naming as ChangeFreqEnum would be more consistent

changed

@bluwy bluwy changed the title fix: types Export ChangeFreqEnum type for sitemap integration May 25, 2023
@bluwy bluwy merged commit 6ca3b5a into withastro:main May 25, 2023
7 of 8 checks passed
@astrobot-houston astrobot-houston mentioned this pull request May 25, 2023
@alexanderniebuhr alexanderniebuhr deleted the alexanderniebuhr/sitemap-type-fix branch September 23, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants