Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix middleware typing export #7032

Merged
merged 2 commits into from May 8, 2023
Merged

fix middleware typing export #7032

merged 2 commits into from May 8, 2023

Conversation

raulfdm
Copy link
Contributor

@raulfdm raulfdm commented May 8, 2023

Closes #7017

Changes

This PR fixes the middleware's typing export. Read about the problem on #7017.

pr-astro.mp4

Testing

With the fix applied:

  1. Open the examples/middleware;
  2. check the astro/middleware import (the type should be there)

Docs

No docs change is required since this is a functional change.

@changeset-bot
Copy link

changeset-bot bot commented May 8, 2023

🦋 Changeset detected

Latest commit: e395257

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 8, 2023
packages/astro/package.json Outdated Show resolved Hide resolved
@raulfdm raulfdm requested a review from bluwy May 8, 2023 12:29
.changeset/new-seals-hear.md Outdated Show resolved Hide resolved
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the video showing that it works.

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking after this!

@matthewp
Copy link
Contributor

matthewp commented May 8, 2023

Closes #7017

@matthewp matthewp merged commit 157357e into withastro:main May 8, 2023
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Middleware imports are not being resolved properly in a TS project
4 participants