Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 6672 #7062

Merged
merged 13 commits into from May 30, 2023
Merged

Bug 6672 #7062

merged 13 commits into from May 30, 2023

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented May 11, 2023

Changes

fix #6672

#6672 (comment)

making the component renders the css and js, because the bufferHeadContent function will ignore css and js from component.

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented May 11, 2023

🦋 Changeset detected

Latest commit: a746cee

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 11, 2023
@JerryWu1234 JerryWu1234 marked this pull request as ready for review May 12, 2023 10:44
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label May 30, 2023
@matthewp matthewp merged commit cf62134 into withastro:main May 30, 2023
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request May 30, 2023
bholmesdev added a commit that referenced this pull request Jun 6, 2023
This reverts commit cf62134.
bholmesdev added a commit that referenced this pull request Jun 6, 2023
* Revert "Bug 6672 (#7062)"

This reverts commit cf62134.

* chore: remove unused test

* chore: changeset
natemoo-re pushed a commit to wackbyte/astro that referenced this pull request Jun 6, 2023
…#7307)

* Revert "Bug 6672 (withastro#7062)"

This reverts commit cf62134.

* chore: remove unused test

* chore: changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
2 participants