Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double prepended forward slash in certain cases #7091

Merged
merged 4 commits into from May 15, 2023
Merged

Conversation

MoustaphaDev
Copy link
Member

Changes

Fix a regression where pathname of pages would be prepended with two forward slashes.
I assume this PR #7076 broke some assumptions that we had on the pathname (that it would never have a leading forward slash?).

Testing

Added back the previous tests (without a base)

Docs

N/A bug fix

@changeset-bot
Copy link

changeset-bot bot commented May 15, 2023

🦋 Changeset detected

Latest commit: 08c1b22

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) labels May 15, 2023
@matthewp matthewp merged commit cd410c5 into main May 15, 2023
14 checks passed
@matthewp matthewp deleted the fix-node-base branch May 15, 2023 12:53
@astrobot-houston astrobot-houston mentioned this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants