Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent removal of nested slots within islands #7093

Merged
merged 3 commits into from
May 17, 2023
Merged

Prevent removal of nested slots within islands #7093

merged 3 commits into from
May 17, 2023

Conversation

matthewp
Copy link
Contributor

Changes

Testing

  • Used existing nested slot tests, but expanded and tested every affected framework:
    • React
    • Vue
    • Preact
    • Solid
    • Svelte

Docs

N/A, bug fix

@matthewp matthewp requested a review from a team as a code owner May 15, 2023 16:37
@changeset-bot
Copy link

changeset-bot bot commented May 15, 2023 •
edited

🦋 Changeset detected

Latest commit: ef1d4da

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: integration Related to any renderer integration (scope) semver: minor Change triggers a `minor` release labels May 15, 2023
@github-actions
Copy link
Contributor

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

MoustaphaDev
MoustaphaDev previously requested changes May 15, 2023
View reviewed changes
Copy link
Member

@MoustaphaDev MoustaphaDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking as this is a minor

bluwy
bluwy approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. It looks like #6301 and #6263 are kinda similar issues, but I don't think this PR fixes it.

@sarah11918 sarah11918 removed the request for review from a team May 16, 2023 13:14
@matthewp matthewp merged commit 3d525ef into main May 17, 2023
18 checks passed
@matthewp matthewp deleted the remove-static-slots branch May 17, 2023 14:18
@astrobot-houston astrobot-houston mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@MoustaphaDev MoustaphaDev MoustaphaDev left review comments

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) semver: minor Change triggers a `minor` release
Projects
None yet
Milestone
No milestone
3 participants
@matthewp @bluwy @MoustaphaDev