Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: middleware for API endpoints #7106

Merged
merged 2 commits into from May 17, 2023
Merged

fix: middleware for API endpoints #7106

merged 2 commits into from May 17, 2023

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented May 16, 2023 •
edited

Changes

This PR fixes a bug where the function renderEndpoint was called too early, making the middleware effectively not work for ALL API endpoints.

cc @alex-sherwin

Partially addresses #7070

  • I renamed the function call to callEndpoint;
  • I moved the warning about "simple" endpoints inside the callMiddleware function

Testing

I created two test cases

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented May 16, 2023 •
edited

🦋 Changeset detected

Latest commit: db19439

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 16, 2023
@alex-sherwin alex-sherwin mentioned this pull request May 16, 2023
Closed
@ematipico @bluwy
Update .changeset/long-starfishes-raise.md
db19439 
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
@ematipico ematipico merged commit 075eee0 into main May 17, 2023
14 checks passed
@ematipico ematipico deleted the fix/middleware-for-endpoints branch May 17, 2023 10:48
@astrobot-houston astrobot-houston mentioned this pull request May 17, 2023
Merged
@ematipico ematipico mentioned this pull request May 17, 2023
Merged
@natemoo-re natemoo-re mentioned this pull request Aug 10, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ematipico @bluwy