Markdoc - remove $entry variable
#7244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 85fb722 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
bholmesdev
commented
May 30, 2023
Comment on lines
-195
to
-206
| /** | ||
| * There are two content collection plugins that depend on the same entry data: | ||
| * - `astro:content-imports` - creates module containing the `getCollection()` result. | ||
| * - `astro:content-render-imports` - creates module containing the `collectionEntry.render()` result. | ||
| * | ||
| * We could run the same transforms to generate the slug and parsed data in each plugin, | ||
| * though this would run the user's collection schema _twice_ for each entry. | ||
| * | ||
| * Instead, we've implemented a cache for all content entry data. To avoid race conditions, | ||
| * this may store either the module itself or a queue of promises awaiting this module. | ||
| * See the implementations of `getContentEntryModuleFromCache` and `setContentEntryModuleCache`. | ||
| */ |
There was a problem hiding this comment.
Bye bye big comment 👋
bholmesdev
commented
May 30, 2023
| throw new MarkdocError({ | ||
| message: [ | ||
| `**${String(entry.collection)} → ${String(entry.id)}** contains invalid content:`, |
There was a problem hiding this comment.
The parsed collection and id are no longer passed. For simplicity, just log the file path
matthewp
approved these changes
May 30, 2023
bholmesdev
force-pushed
the
fix/kill-entry
branch
from
6d40c93
to
85fb722
Compare
sarah11918
approved these changes
May 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
$entryvariable for Markdoc entries. This introduced a complex caching layer, leading to complex code comments and race conditions in CI during production builds.getRenderModule()API with additional props to expose debugging information to Markdoc (relied on the "entry" variable for these earlier)getContentEntryModule()andgetDataEntryModule()to align on shared logicTesting
entry-prop.test.jsto a genericvariablestestDocs