Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing styles and scripts on document: {render:null} #7309

Merged
merged 5 commits into from Jun 6, 2023

Conversation

bholmesdev
Copy link
Contributor

Changes

  • Replace the Fragment special case for arrays with a .map from the Renderer. It seems assets aren't propagated when the parent is also a component. Code be an issue with propagation within slots?

Testing

  • Update test case to use README recommendation

Docs

  • Fix backwards spread order in nodes examples

@bholmesdev bholmesdev requested a review from a team as a code owner June 6, 2023 17:03
@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023

🦋 Changeset detected

Latest commit: 3def430

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jun 6, 2023
@bholmesdev bholmesdev merged commit 2a4bb23 into main Jun 6, 2023
14 checks passed
@bholmesdev bholmesdev deleted the fix/document-render-null-breaks-propagation branch June 6, 2023 17:40
@astrobot-houston astrobot-houston mentioned this pull request Jun 6, 2023
natemoo-re pushed a commit to wackbyte/astro that referenced this pull request Jun 6, 2023
…o#7309)

* fix: propagate assets when using document `render: null`

* fix: reverse spread order

* refactor: use README rec in test

* chore: changeset

* chore: revert unneeded changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants