Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@astrojs/svelte: Update to svelte2tsx 0.6.15 and vite-plugin-svelte 2.4.1 #7314

Merged
merged 1 commit into from Jun 6, 2023

Conversation

wackbyte
Copy link
Contributor

@wackbyte wackbyte commented Jun 6, 2023

Changes

  • Bump svelte2tsx from ^0.5.11 to ^0.6.15
  • Bump @sveltejs/vite-plugin-svelte from ^2.1.1 to ^2.4.1
  • Bump svelte from ^3.44.0 from ^3.55.0 (required by svelte2tsx)

Now that svelte2tsx supports TypeScript 5.x, I think its "packageExtensions" can be removed? (I'm not sure)

Testing

I did not add any tests as this is a dependency bump.

Docs

This is a small dependency bump and does not require any documentation changes.

@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023

🦋 Changeset detected

Latest commit: d0890c7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: integration Related to any renderer integration (scope) labels Jun 6, 2023
@natemoo-re natemoo-re requested a review from a team as a code owner June 6, 2023 20:18
@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 6, 2023
@github-actions github-actions bot removed the pkg: astro Related to the core `astro` package (scope) label Jun 6, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable change, thanks for updating these deps!

@natemoo-re natemoo-re merged commit e47e53d into withastro:main Jun 6, 2023
13 checks passed
@wackbyte wackbyte deleted the bump-svelte2tsx branch June 6, 2023 23:09
@astrobot-houston astrobot-houston mentioned this pull request Jun 6, 2023
@bluwy
Copy link
Member

bluwy commented Jun 6, 2023

This is a breaking change as it changes the peer deps required by the dependencies. We'd need to mark it a major in changesets.

bluwy added a commit that referenced this pull request Jun 7, 2023
bluwy added a commit that referenced this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: svelte Related to Svelte (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants