Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an issue where create Astro doesn't respect custom npm registries #7326

Merged
merged 4 commits into from Jun 9, 2023

Conversation

calebdwilliams
Copy link
Contributor

Changes

Testing

I'm not sure how to effectively test this fix without affecting the entire build process. Happy to accept suggestions.

Docs

This should enable Astro to behave as expected for users with custom package registries (such as large enterprises who might block the public npm registry for security or efficiency reasons).

@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2023

🦋 Changeset detected

Latest commit: 0ff4be4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 7, 2023
@calebdwilliams calebdwilliams marked this pull request as draft June 8, 2023 14:54
@github-actions github-actions bot added the pkg: create-astro Related to the `create-astro` package (scope) label Jun 8, 2023
@calebdwilliams calebdwilliams marked this pull request as ready for review June 8, 2023 16:06
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for the PR!

Discussed on Discord and confirmed locally that these changes work both when a user has set a custom registry and when a user has no custom registry defined. Package managers properly return the default NPM registry in the latter case.

@matthewp matthewp merged commit 1430ffb into withastro:main Jun 9, 2023
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants