Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up pnpm dev #7424

Merged
merged 9 commits into from Jun 20, 2023
Merged

Fix up pnpm dev #7424

merged 9 commits into from Jun 20, 2023

Conversation

bholmesdev
Copy link
Contributor

@bholmesdev bholmesdev commented Jun 19, 2023

Changes

  • No more "astro" package red squiggles! 馃コ Avoid deleting .d.ts files in dev. Turns out, we had a bad glob where we clean up files. We need onlyFiles to avoid deleting nested directories.
  • Add "persistent": true with boosted concurrency per turborepo's recommendation.
  • Move src/content/templates to the project root. These were getting crawled by tsc, which throws wacky build errors if you try to build twice!

Testing

  • Manual testing that dev runs and .d.ts files are preserved
  • Checking that "persistent": true = faster dev perf needs extended testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Jun 19, 2023

馃 Changeset detected

Latest commit: bce1418

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

package.json Show resolved Hide resolved
@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 20, 2023
@bholmesdev bholmesdev merged commit 7877a06 into main Jun 20, 2023
14 checks passed
@bholmesdev bholmesdev deleted the hackathon/better-pnpm-dev branch June 20, 2023 18:06
@astrobot-houston astrobot-houston mentioned this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants