Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minior issue in the documentation related to port customization #7436

Merged
merged 3 commits into from Jun 21, 2023

Conversation

kossidts
Copy link
Contributor

@kossidts kossidts commented Jun 20, 2023

Changes

Destructure the argument of the function to customize the Astro dev server based on the command run. (withastro/docs#3532)

Docs

The fix is made in the types file from which the Configuration Reference docs are generated. Hence the fix leads to an update of the documentation.

@kossidts kossidts requested a review from a team as a code owner June 20, 2023 19:35
@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2023

🦋 Changeset detected

Latest commit: d9bad9d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 20, 2023
Copy link
Member

@ElianCodes ElianCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! You're totally right!

@ematipico ematipico merged commit 3943fa3 into withastro:main Jun 21, 2023
14 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants