Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle esbuild 0.18 changes #7479

Merged
merged 1 commit into from Jun 27, 2023
Merged

Handle esbuild 0.18 changes #7479

merged 1 commit into from Jun 27, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jun 26, 2023

Changes

Handle upcoming esbuild 0.18 changes that will be introduced by Vite 4.4. More context at vitejs/vite#13525 (comment) where Astro was failing in vite-ecosystem-ci.

Testing

Manually linked Vite locally and ran test

Docs

n/a.

@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2023

🦋 Changeset detected

Latest commit: a1be7ed

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 26, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, thank you!

@bluwy bluwy merged commit 57e6030 into main Jun 27, 2023
14 checks passed
@bluwy bluwy deleted the handle-esbuild-0.18 branch June 27, 2023 03:59
@astrobot-houston astrobot-houston mentioned this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants