Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirect in SSR (Node and dynamic) #7856

Merged
merged 1 commit into from Jul 28, 2023
Merged

Fix redirect in SSR (Node and dynamic) #7856

merged 1 commit into from Jul 28, 2023

Conversation

matthewp
Copy link
Contributor

Changes

Testing

  • Test assertion was wrong. It was asserting that the redirect was to / which is the fallback if no redirect destination is provided. It should have asserted the location in the config, which is /test.

Docs

N/A, bug fix

@matthewp matthewp requested a review from a team as a code owner July 28, 2023 15:43
@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2023

🦋 Changeset detected

Latest commit: 78eb007

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 28, 2023
@matthewp matthewp merged commit 861f10e into main Jul 28, 2023
14 checks passed
@matthewp matthewp deleted the redir-ssr branch July 28, 2023 16:00
@astrobot-houston astrobot-houston mentioned this pull request Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@astrojs/node is not handling redirects on production
2 participants