Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Astro.cookies.get(key) return undefined #7888

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Make Astro.cookies.get(key) return undefined #7888

merged 1 commit into from
Aug 1, 2023

Conversation

matthewp
Copy link
Contributor

Changes

  • Astro.cookies.get(key) now returns undefined if the cookie isn't present.
  • This is a breaking change, as previously you needed to use has() to check for existence.

Testing

  • Test updated

Docs

  • TBD

@changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2023

🦋 Changeset detected

Latest commit: 9661906

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 31, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a nice change!

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branch must be rebased again, blocking to be safe

@ematipico ematipico merged commit 54c158a into next Aug 1, 2023
13 checks passed
@ematipico ematipico deleted the cookies-get branch August 1, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants