Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MDX components exports handling #7904

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Refactor MDX components exports handling #7904

merged 2 commits into from
Aug 2, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 1, 2023

Changes

Move export const components MDX feature handling from Astro core to MDX integration.

Testing

Existing Astro and MDX tests should pass.

Docs

n/a. Should be transparent when upgraded to latest. Will note in the migration guide issue as so.

@changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 9e17ffb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Aug 1, 2023
@ematipico ematipico requested a review from a team as a code owner August 1, 2023 15:01
@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: example Related to an example package (scope) 🚨 action Modifies GitHub Actions pkg: react Related to React (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) pkg: lit Related to Lit (scope) pkg: create-astro Related to the `create-astro` package (scope) labels Aug 1, 2023
@github-actions github-actions bot removed pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: example Related to an example package (scope) 🚨 action Modifies GitHub Actions pkg: react Related to React (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) pkg: lit Related to Lit (scope) pkg: create-astro Related to the `create-astro` package (scope) labels Aug 1, 2023
natemoo-re
natemoo-re approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! That's a great change.

@bluwy bluwy merged commit 25b8935 into next Aug 2, 2023
13 checks passed
@bluwy bluwy deleted the mdx-components-exports branch August 2, 2023 08:29
@astrobot-houston astrobot-houston mentioned this pull request Aug 2, 2023
Merged
@bluwy bluwy mentioned this pull request Aug 2, 2023
Closed
ematipico pushed a commit that referenced this pull request Aug 3, 2023
@bluwy @ematipico
Refactor MDX components exports handling (#7904)
631b9c4
ematipico pushed a commit that referenced this pull request Aug 8, 2023
@bluwy @ematipico
Refactor MDX components exports handling (#7904)
32669cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bluwy @ematipico @natemoo-re