feat: unflag experimental.assets #7921
Conversation
🦋 Changeset detectedLatest commit: 82c5185 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
feat: markdown
Princesseuh
force-pushed
the
feat/unflagassets
branch
from
f766049
to
90e33d2
Compare
ematipico
force-pushed
the
next
branch
2 times, most recently
from
c19adcd
to
70f34f5
Compare
Princesseuh
force-pushed
the
feat/unflagassets
branch
from
ac757fb
to
f6e10bf
Compare
github-actions
bot
added
pkg: svelte
Princesseuh
force-pushed
the
feat/unflagassets
branch
from
f6e10bf
to
0b17473
Compare
github-actions
bot
removed
pkg: svelte
ematipico
force-pushed
the
feat/unflagassets
branch
from
e84ab92
to
ba4ed10
Compare
Princesseuh
force-pushed
the
feat/unflagassets
branch
from
343d3a0
to
a4d2da1
Compare
There was a problem hiding this comment.
Hey @Princesseuh ! This is exciting.... :houston_intensifies:
Since it's just the changelog for the beta, we probably don't have to get too deep, but I thought that at least adding in that you have to uninstall the old integration, as well as a link to docs (since this is a pretty big change!) might be helpful here. So, something kind of like below I think does a good job of balancing enough warning about the breaking changes without overloading since it's just an experimental beta.
Feel free to use from this what you like!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
| typesEnvContents.includes('types="astro/client-image"') | ||
| ) { | ||
| typesEnvContents = typesEnvContents.replace( | ||
| 'types="astro/client-image"', | ||
| 'types="astro/client"' | ||
| ); |
There was a problem hiding this comment.
@Princesseuh Should this have stayed? Leaving projects at astro/client-image breaks import.meta.env type in non-astro files. Or only update 3.0 migration docs?
There was a problem hiding this comment.
Hmm, it should be mentioned in the 3.0 migration docs, but we probably should've kept this for convenience too... The right type to have in 3.0 is definitely astro/client, no matter what.
There was a problem hiding this comment.
Thanks. Not in migration guide yet. Not breaking builds, so might be enough to mentioned it there.
Wasn't obvious that I had to manually fix it before reading the removed TODO comment in this PR.
Changes
What the title says!
Testing
Updated tests and they should pass!
Docs
Sarah has a PR to docs in flight already for this!