Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(@astrojs/cloudflare): port functionPerRoute #8078

Merged
merged 19 commits into from
Aug 17, 2023
Merged

feature(@astrojs/cloudflare): port functionPerRoute #8078

merged 19 commits into from
Aug 17, 2023

Conversation

alexanderniebuhr
Copy link
Member

@alexanderniebuhr alexanderniebuhr commented Aug 14, 2023

Changes

Testing

  • see ported test

Docs

Since the changelog is copied from an already merged PR, I don't think we need to review it again

@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2023

🦋 Changeset detected

Latest commit: 17c27c8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Aug 14, 2023
@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 14, 2023
@alexanderniebuhr alexanderniebuhr changed the title DRAFT: TBA feature(@astrojs/cloudflare): port functionPerRoute Aug 14, 2023
@alexanderniebuhr alexanderniebuhr marked this pull request as ready for review August 14, 2023 18:21
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much for tackling this!

@natemoo-re natemoo-re mentioned this pull request Aug 14, 2023
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we have to update the README.md, and explain that functionPerRoute is only available when mode is "directory".

.changeset/wise-cameras-agree.md Show resolved Hide resolved
packages/astro/src/core/build/generate.ts Outdated Show resolved Hide resolved
@alexanderniebuhr alexanderniebuhr requested a review from a team as a code owner August 15, 2023 11:18
@alexanderniebuhr
Copy link
Member Author

please review:

  • changesets
  • readme

/cc @withastro/maintainers-docs for feedback!

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alexanderniebuhr ! Thanks for your patience as we're juggling both docs for the current branch that need to be published sooner and these docs for the next branch that won't go live until the end of the month! 😄

I've left a few suggestions (one of them has me shaking my fist at GitHub) for your consideration!

packages/integrations/cloudflare/README.md Outdated Show resolved Hide resolved
.changeset/nasty-garlics-listen.md Outdated Show resolved Hide resolved
.changeset/wise-cameras-agree.md Outdated Show resolved Hide resolved
.changeset/wise-cameras-agree.md Outdated Show resolved Hide resolved
alexanderniebuhr and others added 4 commits August 17, 2023 17:36
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexanderniebuhr, this looks great! Added two small nit comments, after these are addressed LGTM.

.changeset/wise-cameras-agree.md Outdated Show resolved Hide resolved
packages/integrations/cloudflare/README.md Outdated Show resolved Hide resolved
alexanderniebuhr and others added 2 commits August 17, 2023 20:35
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
@natemoo-re
Copy link
Member

Thanks so much again @alexanderniebuhr!

@natemoo-re natemoo-re merged commit 2540fee into withastro:next Aug 17, 2023
13 checks passed
@alexanderniebuhr alexanderniebuhr deleted the alexanderniebuhr/7948-port-functionPerRoute branch September 23, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants