Export astro/compiler-runtime and cleanup exports #8085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7de7182 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ematipico
approved these changes
Aug 15, 2023
|
Merging so Ema can rebase next |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
(Same as changeset)
Remove exports for
astro/internal/*andastro/runtime/server/*in favour ofastro/runtime/*. Add newastro/compiler-runtimeexport for compiler-specific runtime code.Ultimately it would be nice to get rid of
astro/runtime/*and make it all stricter, but that's longer term.Testing
Existing tests should pass.
Docs
We currently don't reference these exports in the docs, which is great since they are internal APIs. The
@astrojs/compilerREADME can use an update after 3.0 is released to recommendastro/compiler-runtimeoverastro/runtime/server/index.js