Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish missing react vnode-children.js file #8228

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Publish missing react vnode-children.js file #8228

merged 2 commits into from
Aug 25, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 25, 2023

Changes

Fix #8135 (comment)

Looks like the fix from #8137 and #8149 got lost when merging to next.

Question: Why in #8137 we export @astrojs/react/vnode-children.js? It doesn't seem like the export is used and documented.

Testing

Didn't test it. The "files" change should work.

Docs

n/a. bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2023

🦋 Changeset detected

Latest commit: 92b3758

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: react Related to React (scope) pkg: integration Related to any renderer integration (scope) labels Aug 25, 2023
@bluwy bluwy merged commit 4bd2fac into main Aug 25, 2023
4 checks passed
@bluwy bluwy deleted the fix-react-export branch August 25, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: react Related to React (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build after @astrojs/react@2.3.0: Could not resolve "./vnode-children.js"
2 participants