Unmount framework components when islands are destroyed #8264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7b1c4f3 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: svelte
matthewp
reviewed
Aug 29, 2023
natemoo-re
force-pushed
the
feat/unmount
branch
from
86d6855
to
b0a3573
Compare
natemoo-re
commented
Aug 29, 2023
Comment on lines
-40
to
-47
| render( | ||
| h( | ||
| Wrapper, | ||
| null, | ||
| h(Component, props, children != null ? h(StaticHtml, { value: children }) : children) | ||
| ), | ||
| parent, | ||
| element |
There was a problem hiding this comment.
This was a hacky solution instead of just using the built-in hydrate function, so I refactored to use that.
Comment on lines
+177
to
+179
| // Only replace the existing body *AFTER* persistent elements are moved over | ||
| // This avoids disconnecting `astro-island` nodes multiple times | ||
| document.body.replaceWith(doc.body); |
There was a problem hiding this comment.
This change was actually important! We replace the persistent islands first, then swap the <body> element. Previously, we would trigger multiple disconnectedCallback in a row when using transition:persist.
matthewp
approved these changes
Aug 29, 2023
ematipico
approved these changes
Aug 29, 2023
Merged
1 task
This was referenced Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
astro:unmountevent when islands are destroyedTesting
Tested manually but I would love to add some E2E tests
Docs
We don't really document how to build a new renderer, but this would be a detail for renderers to handle.