Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@astrojs/vercel): slowness and symbolic link #8348

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

ematipico
Copy link
Member

Changes

Closes #8312

This PR addresses two issues:

  • slowness of the build: our adapter, when bundling a function, needs to carry over the dependencies that are inlined. Unfortunately, some package managers rely on symbolic links, and we need to trace them. This means that most of the time, the base path to start looking for files is the root folder (/ or C:\). On big projects (monorepos), this could cause a lot of overhead. Fortunately, @vercel/nft allows us to pass a cache object to reuse when bundling the functions. The first function to bundle will always be slow, but the next ones are way faster.
  • symbolic link issues: I suppose this is specific to pnpm. Essentially, our adapter carries over the symbolic link of our inlined (external, not bundled) dependencies. After the first run, we have the source of the symbolic link in the pnpm store, so we don't need to create a new one again. Hopefully, this should fix the issue.

Testing

Create a preview release and ask users to try it, and make sure to check if the deployed function works.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2023

🦋 Changeset detected

Latest commit: c66907c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Sep 1, 2023
@ematipico
Copy link
Member Author

!preview vercel-symbolic-link

@ematipico ematipico force-pushed the fix/vercel-symbolic-link-and-slowness branch from bfceeb1 to c66907c Compare September 1, 2023 11:01
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

 > root@0.0.0 release /home/runner/work/astro/astro > pnpm run build && changeset publish "--tag" "next--vercel-symbolic-link" > root@0.0.0 build /home/runner/work/astro/astro > turbo run build --filter=astro --filter=create-astro --filter="@astrojs/*" --filter="@benchmark/*" �[2m• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/deno, @astrojs/internal-helpers, @astrojs/lit, @astrojs/markdoc, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prefetch, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/underscore-redirects, @astrojs/vercel, @astrojs/vue, @benchmark/timer, astro, create-astro�[0m �[2m• Running�[0m �[2m�[1mbuild�[0m�[0m �[2min 27 packages�[0m �[2m• Remote caching enabled�[0m ::group::create-astro:build cache hit, suppressing logs �[2m7cd1fc32bb1de456�[0m ::endgroup:: ::group::@astrojs/internal-helpers:build cache hit, suppressing logs �[2m32b1108bc9e1f437�[0m ::endgroup:: ::group::@astrojs/prism:build cache hit, suppressing logs �[2m846972649e641897�[0m ::endgroup:: ::group::@astrojs/telemetry:build cache hit, suppressing logs �[2m66d379b39ad9ecf6�[0m ::endgroup:: ::group::@astrojs/markdown-remark:build cache hit, suppressing logs �[2mbdafb901dff64766�[0m ::endgroup:: ::group::astro:build cache miss, executing �[2ma9b6c15873a0f639�[0m > astro@0.0.0-vercel-symbolic-link-20230901110045 build /home/runner/work/astro/astro/packages/astro > pnpm run prebuild && astro-scripts build "src/**/*.{ts,js}" && tsc && pnpm run postbuild > astro@0.0.0-vercel-symbolic-link-20230901110045 prebuild /home/runner/work/astro/astro/packages/astro > astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts" > astro@0.0.0-vercel-symbolic-link-20230901110045 postbuild /home/runner/work/astro/astro/packages/astro > astro-scripts copy "src/**/*.astro" && astro-scripts copy "src/**/*.wasm" ::endgroup:: ::group::@astrojs/lit:build cache miss, executing �[2mc2b34cf0af7398a6�[0m > @astrojs/lit@3.0.0 build /home/runner/work/astro/astro/packages/integrations/lit > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@benchmark/timer:build cache miss, executing �[2m32289d26fceecb8a�[0m > @benchmark/timer@0.0.0 build /home/runner/work/astro/astro/benchmark/packages/timer > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/react:build cache miss, executing �[2m81e328acbd05b8a1�[0m > @astrojs/react@3.0.0 build /home/runner/work/astro/astro/packages/integrations/react > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/prefetch:build cache miss, executing �[2m4a8deb3b446ead9c�[0m > @astrojs/prefetch@0.4.0 build /home/runner/work/astro/astro/packages/integrations/prefetch > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/rss:build cache miss, executing �[2ma0d5b5ff22c0db74�[0m > @astrojs/rss@3.0.0 build /home/runner/work/astro/astro/packages/astro-rss > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/solid-js:build cache miss, executing �[2ma95da0155a7ef84e�[0m > @astrojs/solid-js@3.0.0 build /home/runner/work/astro/astro/packages/integrations/solid > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/preact:build cache miss, executing �[2m372b78bfa3e8550c�[0m > @astrojs/preact@3.0.0 build /home/runner/work/astro/astro/packages/integrations/preact > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/node:build cache miss, executing �[2m34c3abe0b854c5d2�[0m > @astrojs/node@6.0.0 build /home/runner/work/astro/astro/packages/integrations/node > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/vercel:build cache miss, executing �[2m9ebf732c4ab50d54�[0m > @astrojs/vercel@4.0.2 build /home/runner/work/astro/astro/packages/integrations/vercel > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/svelte:build cache miss, executing �[2m63abf94769ad2eee�[0m > @astrojs/svelte@4.0.0 build /home/runner/work/astro/astro/packages/integrations/svelte > astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc ::endgroup:: ::group::@astrojs/alpinejs:build cache miss, executing �[2mc7e5d5bd116fb3cd�[0m > @astrojs/alpinejs@0.3.0 build /home/runner/work/astro/astro/packages/integrations/alpinejs > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/tailwind:build cache miss, executing �[2m5e53737f8911ae0c�[0m > @astrojs/tailwind@5.0.0 build /home/runner/work/astro/astro/packages/integrations/tailwind > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/partytown:build cache miss, executing �[2m23587ab4e3b42958�[0m > @astrojs/partytown@2.0.0 build /home/runner/work/astro/astro/packages/integrations/partytown > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/deno:build cache miss, executing �[2m164830af0849cda7�[0m > @astrojs/deno@5.0.0 build /home/runner/work/astro/astro/packages/integrations/deno > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/underscore-redirects:build cache miss, executing �[2m6bc5a5ed95850ab7�[0m > @astrojs/underscore-redirects@0.3.0 build /home/runner/work/astro/astro/packages/underscore-redirects > astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json ::endgroup:: ::group::@astrojs/vue:build cache miss, executing �[2m08b88471d6e63ac7�[0m > @astrojs/vue@3.0.0 build /home/runner/work/astro/astro/packages/integrations/vue > astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc ::endgroup:: ::group::@astrojs/mdx:build cache miss, executing �[2m38b7d224d89ff36f�[0m > @astrojs/mdx@1.0.0 build /home/runner/work/astro/astro/packages/integrations/mdx > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/markdoc:build cache miss, executing �[2mdc921e13fb545529�[0m > @astrojs/markdoc@0.5.0 build /home/runner/work/astro/astro/packages/integrations/markdoc > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/sitemap:build cache miss, executing �[2m2a1106794b2fe346�[0m > @astrojs/sitemap@3.0.0 build /home/runner/work/astro/astro/packages/integrations/sitemap > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/netlify:build cache miss, executing �[2m2d556246a7fb719d�[0m > @astrojs/netlify@3.0.0 build /home/runner/work/astro/astro/packages/integrations/netlify > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/cloudflare:build cache miss, executing �[2m925e7e2d2098d160�[0m > @astrojs/cloudflare@7.0.0 build /home/runner/work/astro/astro/packages/integrations/cloudflare > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: Tasks: 27 successful, 27 total Cached: 5 cached, 27 total Time: 1m4.992s 🦋 �[33mwarn�[39m �[31m===============================IMPORTANT!===============================�[39m 🦋 �[33mwarn�[39m Packages will be released under the next--vercel-symbolic-link tag 🦋 �[33mwarn�[39m �[31m----------------------------------------------------------------------�[39m 🦋 �[36minfo�[39m npm info astro 🦋 �[36minfo�[39m npm info @astrojs/prism 🦋 �[36minfo�[39m npm info @astrojs/rss 🦋 �[36minfo�[39m npm info create-astro 🦋 �[36minfo�[39m npm info @astrojs/alpinejs 🦋 �[36minfo�[39m npm info @astrojs/cloudflare 🦋 �[36minfo�[39m npm info @astrojs/deno 🦋 �[36minfo�[39m npm info @astrojs/lit 🦋 �[36minfo�[39m npm info @astrojs/markdoc 🦋 �[36minfo�[39m npm info @astrojs/mdx 🦋 �[36minfo�[39m npm info @astrojs/netlify 🦋 �[36minfo�[39m npm info @astrojs/node 🦋 �[36minfo�[39m npm info @astrojs/partytown 🦋 �[36minfo�[39m npm info @astrojs/preact 🦋 �[36minfo�[39m npm info @astrojs/prefetch 🦋 �[36minfo�[39m npm info @astrojs/react 🦋 �[36minfo�[39m npm info @astrojs/sitemap 🦋 �[36minfo�[39m npm info @astrojs/solid-js 🦋 �[36minfo�[39m npm info @astrojs/svelte 🦋 �[36minfo�[39m npm info @astrojs/tailwind 🦋 �[36minfo�[39m npm info @astrojs/vercel 🦋 �[36minfo�[39m npm info @astrojs/vue 🦋 �[36minfo�[39m npm info @astrojs/internal-helpers 🦋 �[36minfo�[39m npm info @astrojs/markdown-remark 🦋 �[36minfo�[39m npm info @astrojs/telemetry 🦋 �[36minfo�[39m npm info @astrojs/underscore-redirects 🦋 �[36minfo�[39m astro is being published because our local version (0.0.0-vercel-symbolic-link-20230901110045) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/prism is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/rss is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m create-astro is not being published because version 4.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/alpinejs is not being published because version 0.3.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/cloudflare is not being published because version 7.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/deno is not being published because version 5.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/lit is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdoc is not being published because version 0.5.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/mdx is not being published because version 1.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/netlify is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/node is not being published because version 6.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/partytown is not being published because version 2.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/preact is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/prefetch is not being published because version 0.4.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/react is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/sitemap is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/solid-js is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/svelte is not being published because version 4.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/tailwind is not being published because version 5.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vercel is not being published because version 4.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vue is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/internal-helpers is not being published because version 0.2.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdown-remark is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/telemetry is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/underscore-redirects is not being published because version 0.3.0 is already published on npm 🦋 �[36minfo�[39m Publishing �[36m"astro"�[39m at �[32m"0.0.0-vercel-symbolic-link-20230901110045"�[39m 🦋 �[32msuccess�[39m packages published successfully: 🦋 astro@0.0.0-vercel-symbolic-link-20230901110045 🦋 Creating git tag... 🦋 New tag: astro@0.0.0-vercel-symbolic-link-20230901110045

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Let’s get user confirmation that this fixes the issue before releasing

Comment on lines +79 to +80
// NOTE: when building function per route, dependencies are linked at the first run, then there's no need anymore to do that once more.
// So we check if the destination already exists. If it does, move on.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But doesn't every function get its own node_modules?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but inside a function we have symbolic links:

Screenshot 2023-09-01 at 13 16 08

This is pnpm doing its own thing I guess

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full disclosure, it's still something a bit foggy to me, especially that part of the code. It's possible my comment is wrong

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

 > root@0.0.0 release /home/runner/work/astro/astro > pnpm run build && changeset publish "--tag" "next--symbolic-link" > root@0.0.0 build /home/runner/work/astro/astro > turbo run build --filter=astro --filter=create-astro --filter="@astrojs/*" --filter="@benchmark/*" �[2m• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/deno, @astrojs/internal-helpers, @astrojs/lit, @astrojs/markdoc, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prefetch, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/underscore-redirects, @astrojs/vercel, @astrojs/vue, @benchmark/timer, astro, create-astro�[0m �[2m• Running�[0m �[2m�[1mbuild�[0m�[0m �[2min 27 packages�[0m �[2m• Remote caching enabled�[0m ::group::@astrojs/internal-helpers:build cache hit, suppressing logs �[2m32b1108bc9e1f437�[0m ::endgroup:: ::group::@astrojs/telemetry:build cache hit, suppressing logs �[2m66d379b39ad9ecf6�[0m ::endgroup:: ::group::create-astro:build cache hit, suppressing logs �[2m7cd1fc32bb1de456�[0m ::endgroup:: ::group::@astrojs/prism:build cache hit, suppressing logs �[2m846972649e641897�[0m ::endgroup:: ::group::@astrojs/markdown-remark:build cache hit, suppressing logs �[2mbdafb901dff64766�[0m ::endgroup:: ::group::astro:build cache miss, executing �[2m811f00db5775b878�[0m > astro@0.0.0-symbolic-link-20230901124103 build /home/runner/work/astro/astro/packages/astro > pnpm run prebuild && astro-scripts build "src/**/*.{ts,js}" && tsc && pnpm run postbuild > astro@0.0.0-symbolic-link-20230901124103 prebuild /home/runner/work/astro/astro/packages/astro > astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts" > astro@0.0.0-symbolic-link-20230901124103 postbuild /home/runner/work/astro/astro/packages/astro > astro-scripts copy "src/**/*.astro" && astro-scripts copy "src/**/*.wasm" ::endgroup:: ::group::@astrojs/alpinejs:build cache miss, executing �[2m48343b8c69bac423�[0m > @astrojs/alpinejs@0.3.0 build /home/runner/work/astro/astro/packages/integrations/alpinejs > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@benchmark/timer:build cache miss, executing �[2m48cafb85d3e12c06�[0m > @benchmark/timer@0.0.0 build /home/runner/work/astro/astro/benchmark/packages/timer > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/react:build cache miss, executing �[2mfc8d7024565933ac�[0m > @astrojs/react@3.0.0 build /home/runner/work/astro/astro/packages/integrations/react > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/lit:build cache miss, executing �[2mea8aff3d4c665118�[0m > @astrojs/lit@3.0.0 build /home/runner/work/astro/astro/packages/integrations/lit > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/rss:build cache miss, executing �[2m76eafc6474e62493�[0m > @astrojs/rss@3.0.0 build /home/runner/work/astro/astro/packages/astro-rss > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/solid-js:build cache miss, executing �[2m0105b85a7fd61081�[0m > @astrojs/solid-js@3.0.0 build /home/runner/work/astro/astro/packages/integrations/solid > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/mdx:build cache miss, executing �[2m1509269d118a9c69�[0m > @astrojs/mdx@1.0.0 build /home/runner/work/astro/astro/packages/integrations/mdx > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/vercel:build cache miss, executing �[2me147dfff1e206f50�[0m > @astrojs/vercel@0.0.0-symbolic-link-20230901124103 build /home/runner/work/astro/astro/packages/integrations/vercel > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/svelte:build cache miss, executing �[2m03d7e2b17ee772fb�[0m > @astrojs/svelte@4.0.0 build /home/runner/work/astro/astro/packages/integrations/svelte > astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc ::endgroup:: ::group::@astrojs/markdoc:build cache miss, executing �[2m708b1da459532c37�[0m > @astrojs/markdoc@0.5.0 build /home/runner/work/astro/astro/packages/integrations/markdoc > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/underscore-redirects:build cache miss, executing �[2m9d1cbf930d79c3a8�[0m > @astrojs/underscore-redirects@0.3.0 build /home/runner/work/astro/astro/packages/underscore-redirects > astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json ::endgroup:: ::group::@astrojs/partytown:build cache miss, executing �[2mad923338e0fe4883�[0m > @astrojs/partytown@2.0.0 build /home/runner/work/astro/astro/packages/integrations/partytown > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/prefetch:build cache miss, executing �[2m1c3f853b9cf50ae6�[0m > @astrojs/prefetch@0.4.0 build /home/runner/work/astro/astro/packages/integrations/prefetch > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/deno:build cache miss, executing �[2mf0cca9dc72783230�[0m > @astrojs/deno@5.0.0 build /home/runner/work/astro/astro/packages/integrations/deno > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/node:build cache miss, executing �[2m2979ced3ce50eb05�[0m > @astrojs/node@6.0.0 build /home/runner/work/astro/astro/packages/integrations/node > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/tailwind:build cache miss, executing �[2m99dfd48e5aac4d6b�[0m > @astrojs/tailwind@5.0.0 build /home/runner/work/astro/astro/packages/integrations/tailwind > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/preact:build cache miss, executing �[2m8f8822fab11e5338�[0m > @astrojs/preact@3.0.0 build /home/runner/work/astro/astro/packages/integrations/preact > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/vue:build cache miss, executing �[2m1e65202d1edff5e9�[0m > @astrojs/vue@3.0.0 build /home/runner/work/astro/astro/packages/integrations/vue > astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc ::endgroup:: ::group::@astrojs/cloudflare:build cache miss, executing �[2m1cc44ac21ad0fb6a�[0m > @astrojs/cloudflare@7.0.0 build /home/runner/work/astro/astro/packages/integrations/cloudflare > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/netlify:build cache miss, executing �[2m28c1d4f21b37fca7�[0m > @astrojs/netlify@3.0.0 build /home/runner/work/astro/astro/packages/integrations/netlify > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/sitemap:build cache miss, executing �[2mc129c6024755c840�[0m > @astrojs/sitemap@3.0.0 build /home/runner/work/astro/astro/packages/integrations/sitemap > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: Tasks: 27 successful, 27 total Cached: 5 cached, 27 total Time: 1m27.268s 🦋 �[33mwarn�[39m �[31m===============================IMPORTANT!===============================�[39m 🦋 �[33mwarn�[39m Packages will be released under the next--symbolic-link tag 🦋 �[33mwarn�[39m �[31m----------------------------------------------------------------------�[39m 🦋 �[36minfo�[39m npm info astro 🦋 �[36minfo�[39m npm info @astrojs/prism 🦋 �[36minfo�[39m npm info @astrojs/rss 🦋 �[36minfo�[39m npm info create-astro 🦋 �[36minfo�[39m npm info @astrojs/alpinejs 🦋 �[36minfo�[39m npm info @astrojs/cloudflare 🦋 �[36minfo�[39m npm info @astrojs/deno 🦋 �[36minfo�[39m npm info @astrojs/lit 🦋 �[36minfo�[39m npm info @astrojs/markdoc 🦋 �[36minfo�[39m npm info @astrojs/mdx 🦋 �[36minfo�[39m npm info @astrojs/netlify 🦋 �[36minfo�[39m npm info @astrojs/node 🦋 �[36minfo�[39m npm info @astrojs/partytown 🦋 �[36minfo�[39m npm info @astrojs/preact 🦋 �[36minfo�[39m npm info @astrojs/prefetch 🦋 �[36minfo�[39m npm info @astrojs/react 🦋 �[36minfo�[39m npm info @astrojs/sitemap 🦋 �[36minfo�[39m npm info @astrojs/solid-js 🦋 �[36minfo�[39m npm info @astrojs/svelte 🦋 �[36minfo�[39m npm info @astrojs/tailwind 🦋 �[36minfo�[39m npm info @astrojs/vercel 🦋 �[36minfo�[39m npm info @astrojs/vue 🦋 �[36minfo�[39m npm info @astrojs/internal-helpers 🦋 �[36minfo�[39m npm info @astrojs/markdown-remark 🦋 �[36minfo�[39m npm info @astrojs/telemetry 🦋 �[36minfo�[39m npm info @astrojs/underscore-redirects 🦋 �[36minfo�[39m astro is being published because our local version (0.0.0-symbolic-link-20230901124103) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/prism is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/rss is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m create-astro is not being published because version 4.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/alpinejs is not being published because version 0.3.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/cloudflare is not being published because version 7.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/deno is not being published because version 5.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/lit is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdoc is not being published because version 0.5.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/mdx is not being published because version 1.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/netlify is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/node is not being published because version 6.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/partytown is not being published because version 2.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/preact is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/prefetch is not being published because version 0.4.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/react is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/sitemap is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/solid-js is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/svelte is not being published because version 4.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/tailwind is not being published because version 5.0.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/vercel is being published because our local version (0.0.0-symbolic-link-20230901124103) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/vue is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/internal-helpers is not being published because version 0.2.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdown-remark is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/telemetry is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/underscore-redirects is not being published because version 0.3.0 is already published on npm 🦋 �[36minfo�[39m Publishing �[36m"astro"�[39m at �[32m"0.0.0-symbolic-link-20230901124103"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/vercel"�[39m at �[32m"0.0.0-symbolic-link-20230901124103"�[39m 🦋 �[32msuccess�[39m packages published successfully: 🦋 astro@0.0.0-symbolic-link-20230901124103 🦋 @astrojs/vercel@0.0.0-symbolic-link-20230901124103 🦋 Creating git tags... 🦋 New tag: astro@0.0.0-symbolic-link-20230901124103 🦋 New tag: @astrojs/vercel@0.0.0-symbolic-link-20230901124103

@ematipico ematipico merged commit 5f2c55b into main Sep 1, 2023
13 checks passed
@ematipico ematipico deleted the fix/vercel-symbolic-link-and-slowness branch September 1, 2023 13:33
@astrobot-houston astrobot-houston mentioned this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Astro v3 pnpm build fails, symlink
3 participants