Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add location data to MDX compile errors #8405

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Conversation

delucis
Copy link
Member

@delucis delucis commented Sep 4, 2023

Changes

Testing

Tested with a patch. I guess existing tests should pass.

Do we otherwise test error handling?

Docs

N/A

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Sep 4, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2023

🦋 Changeset detected

Latest commit: 20848b2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a question left

packages/integrations/mdx/src/index.ts Show resolved Hide resolved
@delucis delucis merged commit 93a1231 into main Sep 5, 2023
13 checks passed
@delucis delucis deleted the dx-571/mdx-error-messages branch September 5, 2023 10:48
@astrobot-houston astrobot-houston mentioned this pull request Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improving the error message in building process
2 participants