Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass our domains and remote config to the Vercel config #8452

Merged
merged 4 commits into from
Sep 7, 2023

Conversation

Princesseuh
Copy link
Member

Changes

Vercel uses the same format we do for domains and remotePatterns, so we can pass ours to their config and it'll work magically.

Fix #8173

Testing

Updated test to check that it generates the proper config

Docs

Updated README

@Princesseuh Princesseuh requested a review from a team as a code owner September 7, 2023 15:36
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Sep 7, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

🦋 Changeset detected

Latest commit: 64555e4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Princesseuh Princesseuh merged commit 7ea32c7 into main Sep 7, 2023
13 checks passed
@Princesseuh Princesseuh deleted the fix/vercel-remote-domains branch September 7, 2023 16:12
@astrobot-houston astrobot-houston mentioned this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Astro:assets remote image with vercel ImageService does not use astro domains and remotepatterns
2 participants