Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve create-astro startup performance #8456

Merged
merged 5 commits into from
Sep 13, 2023
Merged

Improve create-astro startup performance #8456

merged 5 commits into from
Sep 13, 2023

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Sep 7, 2023

Changes

  • Avoids blocking create-astro startup on async network requests
  • Adds a console.clear() call at start because PNPM always spits out a bunch of dependencies during pnpm create astro.
  • First Houston now clears after greeting to keep the UI clear
  • Minor change for safety. Also bumps minimum Node version to 16 (not 18 yet just to be safe)

Testing

Tested manually. Existing test suite should work!

Before time pnpm create astro 2.03s to first message
After time pnpm create astro@next--perf 1.32s to first message

Docs

N/A

@github-actions github-actions bot added the pkg: create-astro Related to the `create-astro` package (scope) label Sep 7, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

🦋 Changeset detected

Latest commit: 8a35fb8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

🦋 Changeset detected

Latest commit: beaba06

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@natemoo-re
Copy link
Member Author

!preview perf

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

 > root@0.0.0 release /home/runner/work/astro/astro > pnpm run build && changeset publish "--tag" "next--perf" > root@0.0.0 build /home/runner/work/astro/astro > turbo run build --filter=astro --filter=create-astro --filter="@astrojs/*" --filter="@benchmark/*" �[2m• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/deno, @astrojs/internal-helpers, @astrojs/lit, @astrojs/markdoc, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prefetch, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/underscore-redirects, @astrojs/vercel, @astrojs/vue, @benchmark/timer, astro, create-astro�[0m �[2m• Running�[0m �[2m�[1mbuild�[0m�[0m �[2min 27 packages�[0m �[2m• Remote caching enabled�[0m ::group::@astrojs/prism:build cache hit, suppressing logs �[2md6a81ed3cba41d8b�[0m ::endgroup:: ::group::@astrojs/telemetry:build cache hit, suppressing logs �[2m6c2eb613a35bd8f9�[0m ::endgroup:: ::group::@astrojs/internal-helpers:build cache hit, suppressing logs �[2m5c0b1e7c443b116c�[0m ::endgroup:: ::group::create-astro:build cache miss, executing �[2mff63976fe2ca7d73�[0m > create-astro@0.0.0-perf-20230907211008 build /home/runner/work/astro/astro/packages/create-astro > astro-scripts build "src/index.ts" --bundle && tsc ::endgroup:: ::group::@astrojs/markdown-remark:build cache miss, executing �[2mf9fb8f04cf07d979�[0m > @astrojs/markdown-remark@0.0.0-perf-20230907211008 build /home/runner/work/astro/astro/packages/markdown/remark > astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json ::endgroup:: ::group::astro:build cache miss, executing �[2m55f5069853bb2e1d�[0m > astro@0.0.0-perf-20230907211008 build /home/runner/work/astro/astro/packages/astro > pnpm run prebuild && astro-scripts build "src/**/*.{ts,js}" && tsc && pnpm run postbuild > astro@0.0.0-perf-20230907211008 prebuild /home/runner/work/astro/astro/packages/astro > astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts" > astro@0.0.0-perf-20230907211008 postbuild /home/runner/work/astro/astro/packages/astro > astro-scripts copy "src/**/*.astro" && astro-scripts copy "src/**/*.wasm" ::endgroup:: ::group::@astrojs/tailwind:build cache miss, executing �[2m9bec31312fca369f�[0m > @astrojs/tailwind@5.0.0 build /home/runner/work/astro/astro/packages/integrations/tailwind > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@benchmark/timer:build cache miss, executing �[2mc8e0ef1b4ffd44ae�[0m > @benchmark/timer@0.0.0 build /home/runner/work/astro/astro/benchmark/packages/timer > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/underscore-redirects:build cache miss, executing �[2mf8fdab3c1abd090c�[0m > @astrojs/underscore-redirects@0.3.0 build /home/runner/work/astro/astro/packages/underscore-redirects > astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json ::endgroup:: ::group::@astrojs/react:build cache miss, executing �[2m64f1b3feb8369a5f�[0m > @astrojs/react@0.0.0-perf-20230907211008 build /home/runner/work/astro/astro/packages/integrations/react > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/solid-js:build cache miss, executing �[2me9afce47a7be77a9�[0m > @astrojs/solid-js@0.0.0-perf-20230907211008 build /home/runner/work/astro/astro/packages/integrations/solid > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/preact:build cache miss, executing �[2m2b4828fd8c7bb5ab�[0m > @astrojs/preact@3.0.0 build /home/runner/work/astro/astro/packages/integrations/preact > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/vercel:build cache miss, executing �[2m6142a8582cc717b6�[0m > @astrojs/vercel@0.0.0-perf-20230907211008 build /home/runner/work/astro/astro/packages/integrations/vercel > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/mdx:build cache miss, executing �[2m5665cdd3837ad420�[0m > @astrojs/mdx@0.0.0-perf-20230907211008 build /home/runner/work/astro/astro/packages/integrations/mdx > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/vue:build cache miss, executing �[2m2872605a975482b3�[0m > @astrojs/vue@3.0.0 build /home/runner/work/astro/astro/packages/integrations/vue > astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc ::endgroup:: ::group::@astrojs/markdoc:build cache miss, executing �[2m7753ef6b1936c46e�[0m > @astrojs/markdoc@0.5.0 build /home/runner/work/astro/astro/packages/integrations/markdoc > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/alpinejs:build cache miss, executing �[2mcd04b53997065024�[0m > @astrojs/alpinejs@0.3.0 build /home/runner/work/astro/astro/packages/integrations/alpinejs > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/prefetch:build cache miss, executing �[2m60e1661a3c128b54�[0m > @astrojs/prefetch@0.4.0 build /home/runner/work/astro/astro/packages/integrations/prefetch > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/lit:build cache miss, executing �[2m2e1f66ec107ce5af�[0m > @astrojs/lit@3.0.0 build /home/runner/work/astro/astro/packages/integrations/lit > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/partytown:build cache miss, executing �[2m4df9ffa6f1f6292e�[0m > @astrojs/partytown@2.0.0 build /home/runner/work/astro/astro/packages/integrations/partytown > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/node:build cache miss, executing �[2mc0e36a3d98bd2945�[0m > @astrojs/node@6.0.0 build /home/runner/work/astro/astro/packages/integrations/node > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/deno:build cache miss, executing �[2m2c17f285ea6e25e4�[0m > @astrojs/deno@5.0.0 build /home/runner/work/astro/astro/packages/integrations/deno > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/rss:build cache miss, executing �[2me42847adbb995e47�[0m > @astrojs/rss@3.0.0 build /home/runner/work/astro/astro/packages/astro-rss > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/svelte:build cache miss, executing �[2m92da1a9f0ca74dfd�[0m > @astrojs/svelte@0.0.0-perf-20230907211008 build /home/runner/work/astro/astro/packages/integrations/svelte > astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc ::endgroup:: ::group::@astrojs/netlify:build cache miss, executing �[2m8102c074d46e57fb�[0m > @astrojs/netlify@3.0.1 build /home/runner/work/astro/astro/packages/integrations/netlify > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/cloudflare:build cache miss, executing �[2m673d09f21348e794�[0m > @astrojs/cloudflare@7.0.2 build /home/runner/work/astro/astro/packages/integrations/cloudflare > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/sitemap:build cache miss, executing �[2mac2a2f763ce82250�[0m > @astrojs/sitemap@3.0.0 build /home/runner/work/astro/astro/packages/integrations/sitemap > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: Tasks: 27 successful, 27 total Cached: 3 cached, 27 total Time: 1m8.867s 🦋 �[33mwarn�[39m �[31m===============================IMPORTANT!===============================�[39m 🦋 �[33mwarn�[39m Packages will be released under the next--perf tag 🦋 �[33mwarn�[39m �[31m----------------------------------------------------------------------�[39m 🦋 �[36minfo�[39m npm info astro 🦋 �[36minfo�[39m npm info @astrojs/prism 🦋 �[36minfo�[39m npm info @astrojs/rss 🦋 �[36minfo�[39m npm info create-astro 🦋 �[36minfo�[39m npm info @astrojs/alpinejs 🦋 �[36minfo�[39m npm info @astrojs/cloudflare 🦋 �[36minfo�[39m npm info @astrojs/deno 🦋 �[36minfo�[39m npm info @astrojs/lit 🦋 �[36minfo�[39m npm info @astrojs/markdoc 🦋 �[36minfo�[39m npm info @astrojs/mdx 🦋 �[36minfo�[39m npm info @astrojs/netlify 🦋 �[36minfo�[39m npm info @astrojs/node 🦋 �[36minfo�[39m npm info @astrojs/partytown 🦋 �[36minfo�[39m npm info @astrojs/preact 🦋 �[36minfo�[39m npm info @astrojs/prefetch 🦋 �[36minfo�[39m npm info @astrojs/react 🦋 �[36minfo�[39m npm info @astrojs/sitemap 🦋 �[36minfo�[39m npm info @astrojs/solid-js 🦋 �[36minfo�[39m npm info @astrojs/svelte 🦋 �[36minfo�[39m npm info @astrojs/tailwind 🦋 �[36minfo�[39m npm info @astrojs/vercel 🦋 �[36minfo�[39m npm info @astrojs/vue 🦋 �[36minfo�[39m npm info @astrojs/internal-helpers 🦋 �[36minfo�[39m npm info @astrojs/markdown-remark 🦋 �[36minfo�[39m npm info @astrojs/telemetry 🦋 �[36minfo�[39m npm info @astrojs/underscore-redirects 🦋 �[36minfo�[39m astro is being published because our local version (0.0.0-perf-20230907211008) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/prism is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/rss is not being published because version 3.0.0 is already published on npm 🦋 �[36minfo�[39m create-astro is being published because our local version (0.0.0-perf-20230907211008) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/alpinejs is not being published because version 0.3.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/cloudflare is not being published because version 7.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/deno is not being published because version 5.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/lit is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdoc is not being published because version 0.5.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/mdx is being published because our local version (0.0.0-perf-20230907211008) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/netlify is not being published because version 3.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/node is not being published because version 6.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/partytown is not being published because version 2.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/preact is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/prefetch is not being published because version 0.4.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/react is being published because our local version (0.0.0-perf-20230907211008) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/sitemap is not being published because version 3.0.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/solid-js is being published because our local version (0.0.0-perf-20230907211008) has not been published on npm 🦋 �[36minfo�[39m @astrojs/svelte is being published because our local version (0.0.0-perf-20230907211008) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/tailwind is not being published because version 5.0.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/vercel is being published because our local version (0.0.0-perf-20230907211008) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/vue is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/internal-helpers is not being published because version 0.2.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/markdown-remark is being published because our local version (0.0.0-perf-20230907211008) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/telemetry is not being published because version 3.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/underscore-redirects is not being published because version 0.3.0 is already published on npm 🦋 �[36minfo�[39m Publishing �[36m"astro"�[39m at �[32m"0.0.0-perf-20230907211008"�[39m 🦋 �[36minfo�[39m Publishing �[36m"create-astro"�[39m at �[32m"0.0.0-perf-20230907211008"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/mdx"�[39m at �[32m"0.0.0-perf-20230907211008"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/react"�[39m at �[32m"0.0.0-perf-20230907211008"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/solid-js"�[39m at �[32m"0.0.0-perf-20230907211008"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/svelte"�[39m at �[32m"0.0.0-perf-20230907211008"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/vercel"�[39m at �[32m"0.0.0-perf-20230907211008"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/markdown-remark"�[39m at �[32m"0.0.0-perf-20230907211008"�[39m 🦋 �[32msuccess�[39m packages published successfully: 🦋 astro@0.0.0-perf-20230907211008 🦋 create-astro@0.0.0-perf-20230907211008 🦋 @astrojs/mdx@0.0.0-perf-20230907211008 🦋 @astrojs/react@0.0.0-perf-20230907211008 🦋 @astrojs/solid-js@0.0.0-perf-20230907211008 🦋 @astrojs/svelte@0.0.0-perf-20230907211008 🦋 @astrojs/vercel@0.0.0-perf-20230907211008 🦋 @astrojs/markdown-remark@0.0.0-perf-20230907211008 🦋 Creating git tags... 🦋 New tag: astro@0.0.0-perf-20230907211008 🦋 New tag: create-astro@0.0.0-perf-20230907211008 🦋 New tag: @astrojs/mdx@0.0.0-perf-20230907211008 🦋 New tag: @astrojs/react@0.0.0-perf-20230907211008 🦋 New tag: @astrojs/solid-js@0.0.0-perf-20230907211008 🦋 New tag: @astrojs/svelte@0.0.0-perf-20230907211008 🦋 New tag: @astrojs/vercel@0.0.0-perf-20230907211008 🦋 New tag: @astrojs/markdown-remark@0.0.0-perf-20230907211008

@natemoo-re
Copy link
Member Author

!preview perf

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

 > root@0.0.0 release /home/runner/work/astro/astro > pnpm run build && changeset publish "--tag" "next--perf" > root@0.0.0 build /home/runner/work/astro/astro > turbo run build --filter=astro --filter=create-astro --filter="@astrojs/*" --filter="@benchmark/*" �[2m• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/deno, @astrojs/internal-helpers, @astrojs/lit, @astrojs/markdoc, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prefetch, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/underscore-redirects, @astrojs/vercel, @astrojs/vue, @benchmark/timer, astro, create-astro�[0m �[2m• Running�[0m �[2m�[1mbuild�[0m�[0m �[2min 27 packages�[0m �[2m• Remote caching enabled�[0m ::group::@astrojs/internal-helpers:build cache hit, suppressing logs �[2m5c0b1e7c443b116c�[0m ::endgroup:: ::group::@astrojs/prism:build cache hit, suppressing logs �[2md6a81ed3cba41d8b�[0m ::endgroup:: ::group::@astrojs/telemetry:build cache hit, suppressing logs �[2m6c2eb613a35bd8f9�[0m ::endgroup:: ::group::create-astro:build cache miss, executing �[2mfc344fb46cabd349�[0m > create-astro@0.0.0-perf-20230907211643 build /home/runner/work/astro/astro/packages/create-astro > astro-scripts build "src/index.ts" --bundle && tsc ::endgroup:: ::group::@astrojs/markdown-remark:build cache miss, executing �[2m6c95c528a2799158�[0m > @astrojs/markdown-remark@0.0.0-perf-20230907211643 build /home/runner/work/astro/astro/packages/markdown/remark > astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json ::endgroup:: ::group::astro:build cache miss, executing �[2m9ba109dab952e75f�[0m > astro@0.0.0-perf-20230907211643 build /home/runner/work/astro/astro/packages/astro > pnpm run prebuild && astro-scripts build "src/**/*.{ts,js}" && tsc && pnpm run postbuild > astro@0.0.0-perf-20230907211643 prebuild /home/runner/work/astro/astro/packages/astro > astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts" > astro@0.0.0-perf-20230907211643 postbuild /home/runner/work/astro/astro/packages/astro > astro-scripts copy "src/**/*.astro" && astro-scripts copy "src/**/*.wasm" ::endgroup:: ::group::@astrojs/alpinejs:build cache miss, executing �[2m3c00fe138941c3da�[0m > @astrojs/alpinejs@0.3.0 build /home/runner/work/astro/astro/packages/integrations/alpinejs > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/deno:build cache miss, executing �[2mb47ddfe6e6a09af6�[0m > @astrojs/deno@5.0.0 build /home/runner/work/astro/astro/packages/integrations/deno > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/lit:build cache miss, executing �[2m6ba118887a4805c3�[0m > @astrojs/lit@3.0.0 build /home/runner/work/astro/astro/packages/integrations/lit > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/underscore-redirects:build cache miss, executing �[2m687b68ff6c272e2a�[0m > @astrojs/underscore-redirects@0.3.0 build /home/runner/work/astro/astro/packages/underscore-redirects > astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json ::endgroup:: ::group::@astrojs/tailwind:build cache miss, executing �[2m980056e6f12ced3f�[0m > @astrojs/tailwind@5.0.0 build /home/runner/work/astro/astro/packages/integrations/tailwind > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/react:build cache miss, executing �[2m07ad2fa091baca75�[0m > @astrojs/react@0.0.0-perf-20230907211643 build /home/runner/work/astro/astro/packages/integrations/react > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/node:build cache miss, executing �[2mc1272b4dce51e43f�[0m > @astrojs/node@6.0.0 build /home/runner/work/astro/astro/packages/integrations/node > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/mdx:build cache miss, executing �[2mf560253e69fd8ffa�[0m > @astrojs/mdx@0.0.0-perf-20230907211643 build /home/runner/work/astro/astro/packages/integrations/mdx > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/markdoc:build cache miss, executing �[2mebc41d90d4e7bcb0�[0m > @astrojs/markdoc@0.5.0 build /home/runner/work/astro/astro/packages/integrations/markdoc > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/vue:build cache miss, executing �[2ma994a69077bc6ad5�[0m > @astrojs/vue@3.0.0 build /home/runner/work/astro/astro/packages/integrations/vue > astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc ::endgroup:: ::group::@benchmark/timer:build cache miss, executing �[2m8c9dce38bba86c12�[0m > @benchmark/timer@0.0.0 build /home/runner/work/astro/astro/benchmark/packages/timer > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/prefetch:build cache miss, executing �[2m963a4248c02a6583�[0m > @astrojs/prefetch@0.4.0 build /home/runner/work/astro/astro/packages/integrations/prefetch > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/preact:build cache miss, executing �[2mbfd6954ab98a7086�[0m > @astrojs/preact@3.0.0 build /home/runner/work/astro/astro/packages/integrations/preact > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/solid-js:build cache miss, executing �[2m8cb2593969d3387c�[0m > @astrojs/solid-js@0.0.0-perf-20230907211643 build /home/runner/work/astro/astro/packages/integrations/solid > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/partytown:build cache miss, executing �[2m1469672725093bb6�[0m > @astrojs/partytown@2.0.0 build /home/runner/work/astro/astro/packages/integrations/partytown > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/vercel:build cache miss, executing �[2mfc042fcd41856f7a�[0m > @astrojs/vercel@0.0.0-perf-20230907211643 build /home/runner/work/astro/astro/packages/integrations/vercel > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/svelte:build cache miss, executing �[2m82fca8f87edde9b5�[0m > @astrojs/svelte@0.0.0-perf-20230907211643 build /home/runner/work/astro/astro/packages/integrations/svelte > astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc ::endgroup:: ::group::@astrojs/rss:build cache miss, executing �[2mb1adbabd760d1f47�[0m > @astrojs/rss@3.0.0 build /home/runner/work/astro/astro/packages/astro-rss > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/cloudflare:build cache miss, executing �[2m9a270ee09149172e�[0m > @astrojs/cloudflare@7.0.2 build /home/runner/work/astro/astro/packages/integrations/cloudflare > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/netlify:build cache miss, executing �[2m84323754cb3936dd�[0m > @astrojs/netlify@3.0.1 build /home/runner/work/astro/astro/packages/integrations/netlify > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/sitemap:build cache miss, executing �[2mc9f37c3ee5803772�[0m > @astrojs/sitemap@3.0.0 build /home/runner/work/astro/astro/packages/integrations/sitemap > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: Tasks: 27 successful, 27 total Cached: 3 cached, 27 total Time: 1m8.135s 🦋 �[33mwarn�[39m �[31m===============================IMPORTANT!===============================�[39m 🦋 �[33mwarn�[39m Packages will be released under the next--perf tag 🦋 �[33mwarn�[39m �[31m----------------------------------------------------------------------�[39m 🦋 �[36minfo�[39m npm info astro 🦋 �[36minfo�[39m npm info @astrojs/prism 🦋 �[36minfo�[39m npm info @astrojs/rss 🦋 �[36minfo�[39m npm info create-astro 🦋 �[36minfo�[39m npm info @astrojs/alpinejs 🦋 �[36minfo�[39m npm info @astrojs/cloudflare 🦋 �[36minfo�[39m npm info @astrojs/deno 🦋 �[36minfo�[39m npm info @astrojs/lit 🦋 �[36minfo�[39m npm info @astrojs/markdoc 🦋 �[36minfo�[39m npm info @astrojs/mdx 🦋 �[36minfo�[39m npm info @astrojs/netlify 🦋 �[36minfo�[39m npm info @astrojs/node 🦋 �[36minfo�[39m npm info @astrojs/partytown 🦋 �[36minfo�[39m npm info @astrojs/preact 🦋 �[36minfo�[39m npm info @astrojs/prefetch 🦋 �[36minfo�[39m npm info @astrojs/react 🦋 �[36minfo�[39m npm info @astrojs/sitemap 🦋 �[36minfo�[39m npm info @astrojs/solid-js 🦋 �[36minfo�[39m npm info @astrojs/svelte 🦋 �[36minfo�[39m npm info @astrojs/tailwind 🦋 �[36minfo�[39m npm info @astrojs/vercel 🦋 �[36minfo�[39m npm info @astrojs/vue 🦋 �[36minfo�[39m npm info @astrojs/internal-helpers 🦋 �[36minfo�[39m npm info @astrojs/markdown-remark 🦋 �[36minfo�[39m npm info @astrojs/telemetry 🦋 �[36minfo�[39m npm info @astrojs/underscore-redirects 🦋 �[36minfo�[39m astro is being published because our local version (0.0.0-perf-20230907211643) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/prism is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/rss is not being published because version 3.0.0 is already published on npm 🦋 �[36minfo�[39m create-astro is being published because our local version (0.0.0-perf-20230907211643) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/alpinejs is not being published because version 0.3.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/cloudflare is not being published because version 7.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/deno is not being published because version 5.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/lit is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdoc is not being published because version 0.5.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/mdx is being published because our local version (0.0.0-perf-20230907211643) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/netlify is not being published because version 3.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/node is not being published because version 6.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/partytown is not being published because version 2.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/preact is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/prefetch is not being published because version 0.4.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/react is being published because our local version (0.0.0-perf-20230907211643) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/sitemap is not being published because version 3.0.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/solid-js is being published because our local version (0.0.0-perf-20230907211643) has not been published on npm 🦋 �[36minfo�[39m @astrojs/svelte is being published because our local version (0.0.0-perf-20230907211643) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/tailwind is not being published because version 5.0.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/vercel is being published because our local version (0.0.0-perf-20230907211643) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/vue is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/internal-helpers is not being published because version 0.2.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/markdown-remark is being published because our local version (0.0.0-perf-20230907211643) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/telemetry is not being published because version 3.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/underscore-redirects is not being published because version 0.3.0 is already published on npm 🦋 �[36minfo�[39m Publishing �[36m"astro"�[39m at �[32m"0.0.0-perf-20230907211643"�[39m 🦋 �[36minfo�[39m Publishing �[36m"create-astro"�[39m at �[32m"0.0.0-perf-20230907211643"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/mdx"�[39m at �[32m"0.0.0-perf-20230907211643"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/react"�[39m at �[32m"0.0.0-perf-20230907211643"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/solid-js"�[39m at �[32m"0.0.0-perf-20230907211643"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/svelte"�[39m at �[32m"0.0.0-perf-20230907211643"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/vercel"�[39m at �[32m"0.0.0-perf-20230907211643"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/markdown-remark"�[39m at �[32m"0.0.0-perf-20230907211643"�[39m 🦋 �[32msuccess�[39m packages published successfully: 🦋 astro@0.0.0-perf-20230907211643 🦋 create-astro@0.0.0-perf-20230907211643 🦋 @astrojs/mdx@0.0.0-perf-20230907211643 🦋 @astrojs/react@0.0.0-perf-20230907211643 🦋 @astrojs/solid-js@0.0.0-perf-20230907211643 🦋 @astrojs/svelte@0.0.0-perf-20230907211643 🦋 @astrojs/vercel@0.0.0-perf-20230907211643 🦋 @astrojs/markdown-remark@0.0.0-perf-20230907211643 🦋 Creating git tags... 🦋 New tag: astro@0.0.0-perf-20230907211643 🦋 New tag: create-astro@0.0.0-perf-20230907211643 🦋 New tag: @astrojs/mdx@0.0.0-perf-20230907211643 🦋 New tag: @astrojs/react@0.0.0-perf-20230907211643 🦋 New tag: @astrojs/solid-js@0.0.0-perf-20230907211643 🦋 New tag: @astrojs/svelte@0.0.0-perf-20230907211643 🦋 New tag: @astrojs/vercel@0.0.0-perf-20230907211643 🦋 New tag: @astrojs/markdown-remark@0.0.0-perf-20230907211643

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a slight preference to not clear the console for pnpm and the houston message as it makes the CLI jump around and potentially hides important information. But not a blocker for this PR.

@natemoo-re natemoo-re merged commit ed952b4 into main Sep 13, 2023
13 checks passed
@natemoo-re natemoo-re deleted the perf/create-astro branch September 13, 2023 14:40
@astrobot-houston astrobot-houston mentioned this pull request Sep 13, 2023
@FredKSchott
Copy link
Member

I've definitely seen users report losing something in their history that they needed or wanted from a console.clear() (IIRC snowpack used to do this in it's dev server output and we removed it for this reason). The subjective value of clearing out the npm/pnpm/yarn install noise doesn't outweigh the objective risk of losing useful data from the user's terminal history.

Similar to others this isn't a huge deal / something that will break immediately, but having gone through the full process of adding and removing something like this before I'd definitely recommend reverting the console.clear(). You can solve equally well IMO with a few newlines instead to separate the clean, beautiful create-astro output from the dirty package manager garbage :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: create-astro Related to the `create-astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants