Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn on empty content collections #8640

Merged
merged 2 commits into from Sep 22, 2023
Merged

Warn on empty content collections #8640

merged 2 commits into from Sep 22, 2023

Conversation

matthewp
Copy link
Contributor

Changes

Testing

Docs

N/A

@matthewp matthewp requested a review from a team as a code owner September 22, 2023 16:31
@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2023 •
edited

🦋 Changeset detected

Latest commit: 4627349

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 22, 2023
@TheOtterlord TheOtterlord mentioned this pull request Sep 22, 2023
Closed
TheOtterlord
TheOtterlord reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

packages/astro/src/core/errors/errors-data.ts Outdated Show resolved Hide resolved
@matthewp @TheOtterlord
Update packages/astro/src/core/errors/errors-data.ts
4627349 
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
@matthewp matthewp merged commit f36c429 into main Sep 22, 2023
13 checks passed
@matthewp matthewp deleted the improve-cc-warn branch September 22, 2023 18:12
@astrobot-houston astrobot-houston mentioned this pull request Sep 22, 2023
Merged
@TheOtterlord TheOtterlord mentioned this pull request Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheOtterlord TheOtterlord TheOtterlord left review comments

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthewp @natemoo-re @TheOtterlord