Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for dynamic component usage #8747

Merged
merged 1 commit into from Oct 4, 2023
Merged

Conversation

natemoo-re
Copy link
Member

Changes

  • Closes Unable to resolve a valid export with dynamic component #8746
  • Improves error message when rendering a dynamic component is attempted
  • Our old error was likely an old holdover from before we had a proper error system and docs, and we already had an Astro error for this case!
  • This PR just replaces our old, unhelpful error with a proper AstroError

Testing

Manually confirmed that this worked

Docs

No changes to the error data, just referencing an existing error.

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2023

🦋 Changeset detected

Latest commit: c4cd2b0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 4, 2023
@natemoo-re natemoo-re merged commit d78806d into main Oct 4, 2023
13 checks passed
@natemoo-re natemoo-re deleted the fix/8746 branch October 4, 2023 20:07
@astrobot-houston astrobot-houston mentioned this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to resolve a valid export with dynamic component
2 participants