misc(create): Ignore errors removing directory after download failed #8841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e854639 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: create-astro
Genteure
force-pushed
the
create-rmdir-error
branch
from
ede7ae2
to
5e70159
Compare
1 task
ematipico
approved these changes
Oct 23, 2023
sarah11918
reviewed
Oct 24, 2023
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Merged
natemoo-re
added a commit
that referenced
this pull request
Nov 22, 2023
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
.,./or starts with../.rmdirSyncafter template download failed.This ensures the original "download failed" error is thrown and displayed to the user instead of a "rmdir failed" error which could be confusing.
Closes #8785
Testing
No new tests were added.
The changed function is not covered by existing tests.
Docs
No docs changes were made.
I don't think this behavior detail is worth documenting on
docs.astro.build.