Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with cloudflare node #8925

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

brandonsdebt
Copy link
Contributor

Changes

Testing

Ran it on a cloudflare env with node enabled.

Docs

Already exist here: https://docs.astro.build/de/guides/integrations-guide/cloudflare/#nodejs-compatibility

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2023

🦋 Changeset detected

Latest commit: 8e6a10d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: react Related to React (scope) pkg: integration Related to any renderer integration (scope) labels Oct 26, 2023
@matthewp
Copy link
Contributor

Can you add a changeset? pnpm changeset and follow the prompts.

@alexanderniebuhr
Copy link
Member

alexanderniebuhr commented Nov 10, 2023

@brandonsdebt just checking in, would it be possible for you to add a changeset? I can also take-over if you want, please let us know!

@github-actions github-actions bot added the docs pr A PR that includes documentation for review label Nov 14, 2023
@bluwy bluwy merged commit ac5633b into withastro:main Nov 16, 2023
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Nov 16, 2023
@brandonsdebt brandonsdebt deleted the cloudflare-node branch November 16, 2023 13:49
peng added a commit to peng/astro that referenced this pull request Nov 17, 2023
* main:
  feat(i18n): add `Astro.currentLocale` (withastro#9101)
  [ci] release (withastro#9107)
  Add compatibility with cloudflare node (withastro#8925)
  [ci] format
  Cancel response stream when connection closes (withastro#9071)
  [ci] format
  feat(i18n): apply specific routing logic only to pages (withastro#9091)
  feat(dev-overlay): Hide plugins into a separate menu when there's too many enabled (withastro#9102)
  [ci] format
  Support Svelte 5 (experimental) (withastro#9098)
  [ci] release (withastro#9078)
  [ci] format
  Refactor shikiji syntax highlighting code (withastro#9083)
  [ci] format
  fix: Query params trigger the trailingSlash error in preview mode (withastro#9045)
  fix(assets): bundling regression for specific config on non-Node runtimes (withastro#9087)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs pr A PR that includes documentation for review pkg: integration Related to any renderer integration (scope) pkg: react Related to React (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants