fix: added onError functionality to spinner #9048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
…ode to handle timeout errors
🦋 Changeset detectedLatest commit: 6eaec0c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: create-astro
skirianov
changed the title
|
sorry for the mess @ematipico and @sarah11918 🥲 |
bluwy
reviewed
Nov 10, 2023
bluwy
approved these changes
Nov 10, 2023
ematipico
approved these changes
Nov 10, 2023
Merged
Closed
1 task
natemoo-re
pushed a commit
that referenced
this pull request
Nov 22, 2023
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fixed version of the closed by mistake PR: #8993
@ematipico - sorry, made an error and have to reopen new PR
Changes
Added onError function to handle errors inside spinner if while function throws an errors.
new onError property inside dependencies.ts spinner
while function catches and throws an error if installing dependencies fails
messages.ts/spinner accept new args
pnpm exec changesetTesting
Manual testing.
Docs
This PR does not require changes in docs.