Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rendering): prevent error when slots is keyed into #9179

Merged
merged 4 commits into from Nov 29, 2023
Merged

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Nov 23, 2023

Changes

Testing

Added a case to astro-slots.test.js

Docs

Does not affect usage

Copy link

changeset-bot bot commented Nov 23, 2023

🦋 Changeset detected

Latest commit: d5c585f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 23, 2023
@github-actions github-actions bot added the docs pr A PR that includes documentation for review label Nov 29, 2023
@lilnasy lilnasy marked this pull request as ready for review November 29, 2023 17:53
@lilnasy lilnasy changed the title fix(rendering): pprevent error when slots is keyed into fix(rendering): prevent error when slots is keyed into Nov 29, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@natemoo-re natemoo-re merged commit 3f28336 into main Nov 29, 2023
13 checks passed
@natemoo-re natemoo-re deleted the fix/9178 branch November 29, 2023 21:47
@astrobot-houston astrobot-houston mentioned this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs pr A PR that includes documentation for review pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using slot in a page leads to an error Cannot read properties of null (reading 'default')
4 participants