Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Svelte 5 render slots as snippets #9285

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Allow Svelte 5 render slots as snippets #9285

merged 2 commits into from
Dec 7, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Dec 4, 2023

Changes

Svelte 5 supports snippets in favor of slots: https://svelte-5-preview.vercel.app/docs/snippets#snippets-and-slots

This change allows our custom injected slots to be rendered as snippets.

Testing

Tested manually in the Svelte examples app.

Docs

n/a. bug fix.

Copy link

changeset-bot bot commented Dec 4, 2023

🦋 Changeset detected

Latest commit: ef74b7d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: integration Related to any renderer integration (scope) docs pr A PR that includes documentation for review labels Dec 4, 2023
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple!

@bluwy bluwy merged commit 1aa7fe8 into main Dec 7, 2023
13 checks passed
@bluwy bluwy deleted the svelte-snippet-support branch December 7, 2023 14:47
@astrobot-houston astrobot-houston mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs pr A PR that includes documentation for review pkg: integration Related to any renderer integration (scope) pkg: svelte Related to Svelte (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants