Fix Preact Forwarded Ref components not working in astro files when React integration is enabled #9403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eact integration is enabled
🦋 Changeset detectedLatest commit: a800f7c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: react
natemoo-re
reviewed
Dec 11, 2023
natemoo-re
approved these changes
Dec 11, 2023
natemoo-re
reviewed
Dec 11, 2023
ematipico
approved these changes
Dec 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #9402
Preact's
forwardReffrompreact/compatcan return function components which forward refs, which React does not support (React forward ref components are always objects, never functions, even whenforwardRefis wrapping a function component).Testing
I have not tested this change. What would qualify as a sufficient test as far as the astro maintainers are concerned?
Docs
No need for docs, this just prevents the React integration from picking up Preact components that it cannot render.