Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds automatic, seasonally appropriate messages from Houston #9476

Merged
merged 18 commits into from
Jan 5, 2024

Conversation

ElianCodes
Copy link
Member

@ElianCodes ElianCodes commented Dec 19, 2023

Changes

  • Depends on feat: allow Houston to wear scarfs cli-kit#29
  • Adds a new data/seasonal.ts file that implements seasonally appropriate messages and decorations
  • Automates Houston's decorations (hats, ties) based on the local date / time of year

Testing

Tested locally and regressions are covered by the existing tests!

Docs

No docs

Copy link

changeset-bot bot commented Dec 19, 2023

🦋 Changeset detected

Latest commit: 39f74b4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: create-astro Related to the `create-astro` package (scope) label Dec 19, 2023
@ElianCodes ElianCodes changed the title feat: allow Houston to wear Scarfs feat: add automatic festive Houston Dec 19, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really fun! I'm glad we won't have to manually manage these messages anymore.

A few suggested refactors to organize things a bit better.

packages/create-astro/src/actions/context.ts Outdated Show resolved Hide resolved
packages/create-astro/src/actions/context.ts Outdated Show resolved Hide resolved
packages/create-astro/src/data/festive.ts Outdated Show resolved Hide resolved
packages/create-astro/src/messages.ts Outdated Show resolved Hide resolved
packages/create-astro/src/data/festive.ts Outdated Show resolved Hide resolved
@ElianCodes ElianCodes marked this pull request as ready for review January 4, 2024 12:12
@natemoo-re natemoo-re changed the title feat: add automatic festive Houston Adds automatic, seasonally appropriate messages from Houston Jan 5, 2024
@github-actions github-actions bot added the docs pr A PR that includes documentation for review label Jan 5, 2024
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for implementing this!

@natemoo-re natemoo-re merged commit 651f45b into main Jan 5, 2024
13 checks passed
@natemoo-re natemoo-re deleted the festive-houston branch January 5, 2024 21:00
@astrobot-houston astrobot-houston mentioned this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs pr A PR that includes documentation for review pkg: create-astro Related to the `create-astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants