fix: pin Sharp at old version #9653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7ae82b9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: example
|
!preview pin-sharp |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
|
!preview pin-sharp |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
|
!preview pin-sharp |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
Princesseuh
commented
Jan 10, 2024
packages/astro/package.json
Outdated
| @@ -179,7 +179,7 @@ | |||
| "zod": "^3.22.4" | |||
| }, | |||
| "optionalDependencies": { | |||
| "sharp": "^0.33.1" | |||
| "sharp": "0.32.6" | |||
There was a problem hiding this comment.
This sucks, because users have to do a manual override to use newer versions, but unfortunately, I couldn't figure it out. The semver checks in Sharp cannot really be relaxed, because it (very understandably so) depends on the newer Node API 9. This is a shame because 0.33.0 is otherwise a very very good upgrade making installation much much less troublesome.
Now that Node 20 is the LTS, it's likely that when we'll release 5.0 a majority of our users will be on it, which should make this much easier. In 5.0 we can update our requirements to be ^18.17.0 || >= 20.3.0 or similar, which should cover everything + be understandable by our users.
bluwy
reviewed
Jan 10, 2024
ematipico
approved these changes
Jan 10, 2024
bluwy
approved these changes
Jan 10, 2024
Merged
sean-beard
added a commit
to sean-beard/ping-me
that referenced
this pull request
Jan 16, 2024
aiwaka
added a commit
to aiwaka/under-construction
that referenced
this pull request
Jan 27, 2024
- upgrade dependencies - pin sharp version (c.f. withastro/astro#9653) - fix relative path for import data (the cause unknown)
sean-beard
added a commit
to sean-beard/ping-me
that referenced
this pull request
Feb 10, 2024
sean-beard
added a commit
to sean-beard/ping-me
that referenced
this pull request
Feb 10, 2024
|
FYI: This is blocking Astro installation with Bun / without Node.js because:
The workaround is "overrides": {
"sharp": "^0.33.2"
}Can't wait to see Astro 5... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Sharp's
0.33.0is much better in every single regard to the 0.32.x version, however its semver checks are incompatible with ours, causing it to not install properly for a lot of users using outdated versions of Node. This PR pins it at the old version until Astro 5.0, where we'll presumably raise the Node requirements. Oh well.For reference, Sharp's semver check is
^18.17.0 || ^20.3.0 || >=21.0.0and ours is>=18.14.1Fix #9345
Testing
Tested manually, we were at that version previously so, it definitely does work.
Docs
N/A