Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: i18n as internal middleware #9793

Closed
wants to merge 1 commit into from
Closed

refactor: i18n as internal middleware #9793

wants to merge 1 commit into from

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Jan 23, 2024

Changes

  • The approach will need to reconsidered to make sure edge middleware doesn't include i18n.

Testing

Existing tests should pass.

Docs

Does not affect usage.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2024

⚠️ No Changeset found

Latest commit: 74576a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 23, 2024
@lilnasy
Copy link
Contributor Author

lilnasy commented Jan 28, 2024

Rolling into #9795

@lilnasy lilnasy closed this Jan 28, 2024
@lilnasy lilnasy deleted the i18n-internal-middleware branch January 28, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@lilnasy