Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a name property for DetailsHTMLAttributes #9918

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

LarryIVC
Copy link
Contributor

@LarryIVC LarryIVC commented Feb 1, 2024

Changes

  • Added a property name for <details> HTML element to group several <details>elements.

Testing

Docs

Copy link

changeset-bot bot commented Feb 1, 2024

🦋 Changeset detected

Latest commit: b46e329

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 1, 2024
Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Can you add a changeset (pnpm changeset)?

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

cc @florian-lefebvre I added the changeset

@florian-lefebvre florian-lefebvre linked an issue Feb 1, 2024 that may be closed by this pull request
1 task
@bluwy bluwy merged commit d52529e into withastro:main Feb 1, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add name property to details element
4 participants