Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new 500.astro error prop #8392

Merged
merged 17 commits into from
Jun 19, 2024
Merged

feat: new 500.astro error prop #8392

merged 17 commits into from
Jun 19, 2024

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented May 24, 2024 •
edited

Description (required)

Adds a section about 500.astro.

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 4.11. See astro PR 11134.

@vercel Vercel
Copy link

vercel bot commented May 24, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 10:21am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Jun 19, 2024 10:21am

@florian-lefebvre florian-lefebvre mentioned this pull request May 24, 2024
Merged
@astrobot-houston
Copy link
Contributor

astrobot-houston commented May 24, 2024 •
edited

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en basics/astro-pages.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

ematipico
ematipico reviewed Jun 10, 2024
View reviewed changes
src/content/docs/en/basics/astro-pages.mdx Outdated Show resolved Hide resolved
src/content/docs/en/basics/astro-pages.mdx Outdated Show resolved Hide resolved
src/content/docs/en/basics/astro-pages.mdx Outdated Show resolved Hide resolved
src/content/docs/en/basics/astro-pages.mdx Outdated Show resolved Hide resolved
@ematipico ematipico added this to the 4.11.0 milestone Jun 10, 2024
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Jun 10, 2024
@florian-lefebvre @ematipico
Apply suggestions from code review
775ac40 
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
@florian-lefebvre florian-lefebvre changed the title [do not review] Update astro-pages.mdx Update astro-pages.mdx Jun 10, 2024
@sarah11918
Copy link
Member

Haha @florian-lefebvre I see the title has been changed. Let me know when it's safe to review! 😄

@florian-lefebvre florian-lefebvre marked this pull request as ready for review June 10, 2024 15:29
@florian-lefebvre
Copy link
Member Author

@sarah11918 you're right it's safe now!

sarah11918
sarah11918 reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @florian-lefebvre! Nice work on this, and I'm sure people are going to enjoy the ability to customize this page!

I've added some thoughts, questions for clarification, and suggestions for your consideration. Not everything I'm suggesting is necessarily final wording, but more to give you an idea of the kind of thing I'd expect to see, then you can help make it accurate! 🙌

src/content/docs/en/basics/astro-pages.mdx Outdated Show resolved Hide resolved
src/content/docs/en/basics/astro-pages.mdx Outdated Show resolved Hide resolved
src/content/docs/en/basics/astro-pages.mdx Outdated Show resolved Hide resolved
src/content/docs/en/basics/astro-pages.mdx Outdated Show resolved Hide resolved
src/content/docs/en/basics/astro-pages.mdx Outdated Show resolved Hide resolved
src/content/docs/en/basics/astro-pages.mdx Outdated Show resolved Hide resolved
src/content/docs/en/basics/astro-pages.mdx Outdated Show resolved Hide resolved
src/content/docs/en/basics/astro-pages.mdx Outdated Show resolved Hide resolved
florian-lefebvre and others added 3 commits June 11, 2024 15:25
@florian-lefebvre @sarah11918
Update src/content/docs/en/basics/astro-pages.mdx
db2a936 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@florian-lefebvre @sarah11918
Update src/content/docs/en/basics/astro-pages.mdx
e8fbb00 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@florian-lefebvre @sarah11918
Update src/content/docs/en/basics/astro-pages.mdx
87193d6 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@florian-lefebvre @sarah11918
Apply suggestions from code review
4500000 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@florian-lefebvre @sarah11918
Update src/content/docs/en/basics/astro-pages.mdx
cbd140c 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@florian-lefebvre @sarah11918
Update src/content/docs/en/basics/astro-pages.mdx
15dba1e 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@florian-lefebvre florian-lefebvre changed the title Update astro-pages.mdx feat: new 500.astro error prop Jun 12, 2024
@florian-lefebvre @sarah11918
Update src/content/docs/en/basics/astro-pages.mdx
6779e37 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Jun 18, 2024
sarah11918
sarah11918 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will merge on Thursday with the minor release! 🙌

@sarah11918 sarah11918 changed the base branch from main to 4.11.0 June 19, 2024 10:11
@sarah11918 sarah11918 merged commit 56bfa7f into 4.11.0 Jun 19, 2024
2 of 3 checks passed
@sarah11918 sarah11918 deleted the feat/custom-500-improvements branch June 19, 2024 10:17
@sarah11918 sarah11918 mentioned this pull request Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico left review comments

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@florian-lefebvre @astrobot-houston @sarah11918 @ematipico