New GitHub action workflow for pages #1165
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
blackgirlbytes
changed the title
yanthomasdev
added
the
improve documentation
|
Thanks so much for this @blackgirlbytes and thanks @Pukimaa for coming in with the review! I'm not going to get a review in this evening but I'll take a close look tomorrow morning. Appreciate the contribution! 🙌 |
|
My pleasure. I'm just excited to contribute to Astro. It's such a cool project! And thanks @pukima for catching those issues |
There was a problem hiding this comment.
Thanks so much for this update @blackgirlbytes!
I’ve made a few suggestions. One thing I can’t add inline is that we should remove the :::tip block below the code sample as it’s linking to the github-pages-action which is no longer in use in the updated action.
src/pages/en/guides/deploy/github.md
Outdated
| # Allows you to run this workflow manually from the Actions tab on GitHub. | ||
| workflow_dispatch: | ||
|
|
||
| # Allow this job to push changes to your repository |
There was a problem hiding this comment.
Nit: looks like this needs slightly different indentation to align with the block it refers to:
| # Allow this job to push changes to your repository | |
| # Allow this job to push changes to your repository |
|
Hey @blackgirlbytes! Welcome to the Docs repo! 🥳 I'm just making a note here to remind us that #1110 is also open and touching the page, but I think it starts immediately after the changes you're making here, so we should be good! 😅 Would everyone here mind taking a peek at THAT PR, too, to make sure that all these changes make sense together? @delucis @Pukimaa ? I made some changes on behalf of the author, but haven't heard back from them in a while. So, if that all reads fine with what's going on in this PR, then I'm happy for us to merge that one, as a smaller change first, then update this branch here and continue working out this one. If someone spots something in that PR that does NOT go down smooth with what's going on here, then let's figure that out while we have some active voice in this thread. 😄 Thanks everyone, for this great team effort! |
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Tommy Byrd <tcbyrd@github.com>
Co-authored-by: Tommy Byrd <tcbyrd@github.com>
Co-authored-by: Tommy Byrd <tcbyrd@github.com>
Co-authored-by: James M. Greene <JamesMGreene@github.com>
What kind of changes does this PR include?
Description
BEFORE
AFTER
Working examples:
From engineer at GitHub on the Pages-Actions team: https://github.com/tcbyrd/astro-portfolio-demo/blob/main/.github/workflows/astro-build.yml
My own repo: https://github.com/blackgirlbytes/blackgyalbites-astro has a working example as well