Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Markdown layout props API #1246

Merged
merged 5 commits into from
Aug 9, 2022
Merged

Conversation

bholmesdev
Copy link
Contributor

What kind of changes does this PR include?

  • New or updated content

Description

  • Change "Markdown props" -> "Markdown layout props" for clarity
  • Remove .astro object from Markdown
  • Introduce new props alongside content: headings, rawContent, and compiledContent
  • Update old getHeaders -> getHeadings

@netlify
Copy link

netlify bot commented Aug 9, 2022

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit ea7ab3e
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/62f2f1651309aa0008ffc1fb
😎 Deploy Preview https://deploy-preview-1246--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sarah11918
Copy link
Member

sarah11918 commented Aug 9, 2022

Thanks @bholmesdev ! I will look at this, but FYI there's an existing PR re: Headers -> Headings with problems that we've had sitting here for a while. Do you mind taking a peek at that one while I look at this one to see if its existence is relevant here?

#1107

@bholmesdev
Copy link
Contributor Author

@sarah11918 Ah yes, there will be conflicts with that draft! Looks like @natemoo-re is updating a few references that were removed in this PR. I'd suggest getting this one in first and updating Nate's accordingly.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bholmesdev! Just a couple of quick nits to check on!

src/pages/en/guides/markdown-content.md Outdated Show resolved Hide resolved
src/pages/en/guides/markdown-content.md Outdated Show resolved Hide resolved
bholmesdev and others added 2 commits August 9, 2022 19:44
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@bholmesdev bholmesdev merged commit c552e68 into main Aug 9, 2022
@bholmesdev bholmesdev deleted the edit/new-markdown-layout-props branch August 9, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants