-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Markdown layout props API #1246
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Thanks @bholmesdev ! I will look at this, but FYI there's an existing PR re: Headers -> Headings with problems that we've had sitting here for a while. Do you mind taking a peek at that one while I look at this one to see if its existence is relevant here? |
@sarah11918 Ah yes, there will be conflicts with that draft! Looks like @natemoo-re is updating a few references that were removed in this PR. I'd suggest getting this one in first and updating Nate's accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bholmesdev! Just a couple of quick nits to check on!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
What kind of changes does this PR include?
Description
.astro
object from Markdowncontent
:headings
,rawContent
, andcompiledContent
getHeaders
->getHeadings