Add new “Scripts and Event Handling” guide #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delucis
added
the
add new content
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
delucis
changed the title
delucis
commented
Nov 23, 2022
sarah11918
reviewed
Nov 24, 2022
There was a problem hiding this comment.
This is an amazing page, @delucis! 🚀 I can't wait for it to go live!
I think there might only be 1 or 2 spots to really revisit and nail the explanations, but I've made some possible editing suggestions that are potentially better, if true! You'll see this before I will tomorrow, so some time for you to digest, correct me, and then we can tackle it tomorrow!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
delucis
commented
Nov 24, 2022
sarah11918
reviewed
Nov 24, 2022
sarah11918
reviewed
Nov 24, 2022
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
delucis
commented
Nov 24, 2022
delucis
commented
Nov 24, 2022
|
LGTM! And so begins the downfall of "Components"... (everything's a component) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
Simplifies the “Client-side scripts” section of the Components guide
Adds a new guide to writing
<scripts>— https://deploy-preview-2102--astro-docs-2.netlify.app/en/guides/client-side-scripts/Includes guidance on:
<script>define:vars)Moves detailed content on script bundling and loading out of the Components guide to the new page
Closes No documentation about Web Components #2100
Useful things to answer
How does this feel? It’s a slightly 50-50 page with a reference-y first half and guide-y second half.
Are the examples clear and helpful? I tried to pick things I could distil down but also chose not to dive too deep into custom element syntax etc. as I think that probably is out of scope for the Astro docs.
Given that, are the links helpful? Can people find what they need to know by following them?
Nav bar position? I feel grouping this with both styling & UI frameworks makes sense. Does SSR need to move up/down?