Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WRITING.md] new section for voice #2149

Merged
merged 2 commits into from Dec 8, 2022
Merged

[WRITING.md] new section for voice #2149

merged 2 commits into from Dec 8, 2022

Conversation

sarah11918
Copy link
Member

What kind of changes does this PR include?

  • New or updated content

Added a brief section on "Voice" to the guide with two points:

  • using "you" (if needed) instead of we, we'll, us, let's etc. (You are not there with the reader at this exact moment.) And, I can't believe it needs to be said not to use I, but that came up in something I read/watched so apparently it's a thing. 😅

  • some general guidance re: exclamation points.

(NB: Voice and tone are similar, but since we have a section for Tone that says "mostly follow Google", for now I'm using this section "Voice" for more technical, specific to us, points.)

@netlify
Copy link

netlify bot commented Dec 7, 2022

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 919c5f3
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/639227c8fd1caa000946184b
😎 Deploy Preview https://deploy-preview-2149--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for voicing these points @sarah11918 🎉

@sarah11918 sarah11918 merged commit 7a8b041 into main Dec 8, 2022
@sarah11918 sarah11918 deleted the sarah11918-voice branch December 8, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants