Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript): Add doc for polymorphic type #3263

Merged
merged 5 commits into from
May 18, 2023
Merged

Conversation

Princesseuh
Copy link
Member

What kind of changes does this PR include?

  • New or updated content

Description

withastro/astro#7069 adds a new polymorphic type, this PR adds the docs for it

@netlify
Copy link

netlify bot commented May 16, 2023

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit ac13c4e
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/64665b6f6bc2550008dcf995
😎 Deploy Preview https://deploy-preview-3263--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Princesseuh Princesseuh added the merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) label May 16, 2023
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, people are going to love this @Princesseuh! I left a couple of comments below!

src/content/docs/en/guides/typescript.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/typescript.mdx Show resolved Hide resolved
@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label May 16, 2023
Princesseuh and others added 2 commits May 17, 2023 13:05
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@sarah11918 sarah11918 merged commit b8447c6 into main May 18, 2023
12 checks passed
@sarah11918 sarah11918 deleted the feat/polymorphic-type branch May 18, 2023 17:17
@sarah11918 sarah11918 added the minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants