Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guide: ISR | Incremental Static Regeneration #3527

Closed
wants to merge 14 commits into from

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Jun 19, 2023

What kind of changes does this PR include?

  • New or updated content

Rendered Preview

https://docs-git-fork-lilnasy-main-astrodotbuild.vercel.app/en/guides/incremental-static-regeneration/

@netlify
Copy link

netlify bot commented Jun 19, 2023

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9fb1fe7
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/652d56a4697ea40008e75bea
😎 Deploy Preview https://deploy-preview-3527--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Jun 20, 2023
@lilnasy lilnasy added the help wanted Issues looking for someone to run with them! label Jul 20, 2023
@Alynva
Copy link
Contributor

Alynva commented Jul 25, 2023

I think that you should remove the else block (keep it's content), so when you remove the stale cache, it still runs that code

@lilnasy
Copy link
Contributor Author

lilnasy commented Jul 25, 2023

@Alynva which else do you mean? Could you make a comment in the diff?

Copy link
Contributor

@Alynva Alynva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lilnasy Sorry, I was on mobile. I've added the suggestions now

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe these fixes might help @lilnasy

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering if having new lines in between is intentional to improve readibility. If not I leave this minor suggestion @lilnasy.

@TheOtterlord
Copy link
Member

Heads up!
We've just migrated the docs site from Netlify to Vercel. With that, the Netlify app has been removed, and will no longer update deploy previews. Vercel should post a comment with the new deploy preview the next time this PR is updated.

@sarah11918 sarah11918 added the help - leave feedback Let's crowd source this one! Looking for comments, suggestions, LGTMs! label Nov 24, 2023
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 22, 2023 4:01pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2023 4:01pm

Copy link

vercel bot commented Dec 22, 2023

@sarah11918 is attempting to deploy a commit to the Astro Team on Vercel.

A member of the Team first needs to authorize it.

@sarah11918
Copy link
Member

🫡

@sarah11918 sarah11918 closed this Dec 23, 2023
@selrond
Copy link

selrond commented Jan 13, 2024

Why was this closed?

@lilnasy
Copy link
Contributor Author

lilnasy commented Jan 15, 2024

@selrond It was just sitting in the backlog for too long. We may still revisit this.

Although, a well-edited version of this was published as a blog post on logsnag! You may want check that out.

https://logsnag.com/blog/implementing-isr-in-astro

@aretrace
Copy link

This information should be included in the docs. Astro is particularly attractive for projects that would also happen to greatly benefit from this technique.

@oemer-aran
Copy link

I would also add this to the official docs. It includes deployment details for different hosting services, which are very valuable. Also reading from the official docs conveys more trust than a blog post. I read through the posts on Logsnag. They were really insightful and very well written. But the code is more like a POC (a very good one), which could potentially be extended with real cache providers.

On-Demand Revalidation would really be a killer feature with astro.js. It's the only real missing piece for me. Especially if you want to serve live data from a CMS which has a API request limit, like Sanity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. help - leave feedback Let's crowd source this one! Looking for comments, suggestions, LGTMs! help wanted Issues looking for someone to run with them!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants