New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guide: ISR | Incremental Static Regeneration #3527
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
I think that you should remove the |
@Alynva which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lilnasy Sorry, I was on mobile. I've added the suggestions now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe these fixes might help @lilnasy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering if having new lines in between is intentional to improve readibility. If not I leave this minor suggestion @lilnasy.
Heads up! |
Co-authored-by: Alisson Nunes <alynva@gmail.com>
Co-authored-by: Alisson Nunes <alynva@gmail.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Co-authored-by: Artem Savelev <h3xsoul@gmail.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@sarah11918 is attempting to deploy a commit to the Astro Team on Vercel. A member of the Team first needs to authorize it. |
🫡 |
Why was this closed? |
@selrond It was just sitting in the backlog for too long. We may still revisit this. Although, a well-edited version of this was published as a blog post on logsnag! You may want check that out. |
This information should be included in the docs. Astro is particularly attractive for projects that would also happen to greatly benefit from this technique. |
I would also add this to the official docs. It includes deployment details for different hosting services, which are very valuable. Also reading from the official docs conveys more trust than a blog post. I read through the posts on Logsnag. They were really insightful and very well written. But the code is more like a POC (a very good one), which could potentially be extended with real cache providers. On-Demand Revalidation would really be a killer feature with astro.js. It's the only real missing piece for me. Especially if you want to serve live data from a CMS which has a API request limit, like Sanity. |
What kind of changes does this PR include?
Rendered Preview
https://docs-git-fork-lilnasy-main-astrodotbuild.vercel.app/en/guides/incremental-static-regeneration/