-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add translation status script and workflow #431
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Would love you to have a look at this @delucis & @sarah11918 😄 |
Note: If you want to test this locally outside of GitHub, you will need to set the env variable |
Looks wonderful, @hippotastic ! I'd be super happy with this as a display for our translators! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely stunning work @hippotastic! 🏆
Really struggled to say anything of value here. I have made some suggestions, but I think basically all of this could just be noted down as possibilities for polish in the future. Happy to see this merged as is 👍
return pageData; | ||
} | ||
|
||
tryGetFrontMatterBlock (filePath) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this would simplify your life much, but could you use gray-matter
here? That’s how Astro parses frontmatter, so it’s already a dependency.
Amazing review with lots of valuable feedback and ideas @delucis, thank you so much! I'd love to address your feedback after merging this PR though to get this into production asap so we can start monitoring the behavior on the "real thing" right away. I'd really be happy to keep improving this! |
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Adds a script that creates or updates a special "Translation Status Overview" summary issue on GitHub that provides an overview of the current Astro documentation translation status.
Also adds a GitHub workflow that runs this script on every push to the
main
branch.An example of the summary issue maintained by this script can be seen here:
#438