Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partials guide #5128

Merged
merged 14 commits into from
Oct 26, 2023
Merged

Partials guide #5128

merged 14 commits into from
Oct 26, 2023

Conversation

matthewp
Copy link
Contributor

Description (required)

This documents partials, an RFC that we plan to release as experimental 3.4.

For Astro version: 3.4. See astro PR #8755.

@netlify
Copy link

netlify bot commented Oct 17, 2023 •
edited

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit f59d98d
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/653a8a3afffdf0000833e828
😎 Deploy Preview https://deploy-preview-5128--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewp matthewp mentioned this pull request Oct 17, 2023
Merged
@sarah11918
Copy link
Member

Short docs make me happy 😅

Quick early question @matthewp : do you think this makes sense to include directly on the "Pages" page, since this seems directly related to the concept of a page in Astro?

dreyfus92
dreyfus92 requested changes Oct 17, 2023
View reviewed changes
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @matthewp, I left you some minor suggestions. Let me know what are your thoughts.

src/content/docs/en/guides/partials.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/partials.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/partials.mdx Outdated Show resolved Hide resolved
matthewp and others added 3 commits October 18, 2023 15:28
@matthewp @dreyfus92
Update src/content/docs/en/guides/partials.mdx
d813e26 
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
@matthewp @dreyfus92
Update src/content/docs/en/guides/partials.mdx
5de591f 
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
@matthewp @dreyfus92
Update src/content/docs/en/guides/partials.mdx
1fe76ad 
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
@matthewp
Copy link
Contributor Author

@sarah11918 Ah yes, that does sound better! Let me update this then.

@sarah11918
Copy link
Member

Perfect! I'll take it from here....

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Oct 20, 2023
@matthewp
Copy link
Contributor Author

Love the new edits, no notes from me.

@sarah11918
Copy link
Member

Note: waiting to find out whether other acceptable page files that can have an export statement (e.g. MDX) can also be partials! If so, we'll update all the times we specify astro pages/components only!

sarah11918
sarah11918 approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for minor release! 🥳

@sarah11918 sarah11918 merged commit 39eceec into main Oct 26, 2023
10 checks passed
@sarah11918 sarah11918 deleted the partials branch October 26, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

@dreyfus92 dreyfus92 dreyfus92 requested changes

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthewp @sarah11918 @dreyfus92