New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Astro 4.0 upgrade guide #5481
Astro 4.0 upgrade guide #5481
Conversation
Co-authored-by: Elian <hello@elian.codes> Co-authored-by: Kevin Zuniga Cuellar <kevinzunigacuellar@users.noreply.github.com> Co-authored-by: Atharva Pise <atharvapise19@gmail.com> Co-authored-by: Paul Valladares <dreyfus92@users.noreply.github.com> Co-authored-by: Reuben Tier <TheOtterlord@users.noreply.github.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: HiDeoo <HiDeoo@users.noreply.github.com> Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> Co-authored-by: Reuben Tier <TheOtterlord@users.noreply.github.com> Co-authored-by: Genteure <Genteure@users.noreply.github.com> Co-authored-by: Atharva Pise <atharvapise19@gmail.com> Co-authored-by: Kevin Zuniga Cuellar <kevinzunigacuellar@users.noreply.github.com>
Looking good |
Co-authored-by: Kevin Zuniga Cuellar <46791833+kevinzunigacuellar@users.noreply.github.com>
LGTM! Great work :)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency e.g. v4.0 used above and below or with v3.0/v3.x directly above - maybe doesn't matter. Otherwise looks good to me.
Co-authored-by: Alex Nguyen <dev@alexnguyen.co.nz> Co-authored-by: Kevin Zuniga Cuellar <46791833+kevinzunigacuellar@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! Left my usual nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review, Yan!
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
Co-authored-by: HiDeoo <HiDeoo@users.noreply.github.com> Co-authored-by: Elian <hello@elian.codes> Co-authored-by: Kevin Zuniga Cuellar <kevinzunigacuellar@users.noreply.github.com> Co-authored-by: Atharva Pise <atharvapise19@gmail.com> Co-authored-by: Paul Valladares <dreyfus92@users.noreply.github.com> Co-authored-by: Reuben Tier <TheOtterlord@users.noreply.github.com> Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> Co-authored-by: Genteure <Genteure@users.noreply.github.com> Co-authored-by: Kevin Zuniga Cuellar <46791833+kevinzunigacuellar@users.noreply.github.com> Co-authored-by: Alex Nguyen <dev@alexnguyen.co.nz> Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
Description (required)
v3 -> v4 upgrade guide with breaking changes
Related issues & labels (optional)