Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astro 4.0 upgrade guide #5481

Merged
merged 16 commits into from Dec 3, 2023
Merged

Astro 4.0 upgrade guide #5481

merged 16 commits into from Dec 3, 2023

Conversation

sarah11918
Copy link
Member

@sarah11918 sarah11918 commented Nov 23, 2023

Description (required)

v3 -> v4 upgrade guide with breaking changes

Related issues & labels (optional)

Co-authored-by: Elian <hello@elian.codes>
Co-authored-by: Kevin Zuniga Cuellar <kevinzunigacuellar@users.noreply.github.com>
Co-authored-by: Atharva Pise <atharvapise19@gmail.com>
Co-authored-by: Paul Valladares <dreyfus92@users.noreply.github.com>
Co-authored-by: Reuben Tier <TheOtterlord@users.noreply.github.com>
Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 3, 2023 2:32pm

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Nov 23, 2023
Co-authored-by: HiDeoo <HiDeoo@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Reuben Tier <TheOtterlord@users.noreply.github.com>
Co-authored-by: Genteure <Genteure@users.noreply.github.com>
Co-authored-by: Atharva Pise <atharvapise19@gmail.com>
Co-authored-by: Kevin Zuniga Cuellar <kevinzunigacuellar@users.noreply.github.com>
@Fryuni
Copy link
Member

Fryuni commented Dec 2, 2023

Looking good

Co-authored-by: Kevin Zuniga Cuellar <46791833+kevinzunigacuellar@users.noreply.github.com>
@VoxelMC
Copy link
Contributor

VoxelMC commented Dec 2, 2023

LGTM! Great work :))
Super excited for the changes, too!

Copy link
Contributor

@alexnguyennz alexnguyennz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency e.g. v4.0 used above and below or with v3.0/v3.x directly above - maybe doesn't matter. Otherwise looks good to me.

src/content/docs/en/guides/upgrade-to/v4.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/upgrade-to/v4.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/upgrade-to/v4.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/upgrade-to/v4.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/upgrade-to/v4.mdx Outdated Show resolved Hide resolved
Co-authored-by: Alex Nguyen <dev@alexnguyen.co.nz>
Co-authored-by: Kevin Zuniga Cuellar <46791833+kevinzunigacuellar@users.noreply.github.com>
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Left my usual nits.

src/content/docs/en/guides/upgrade-to/v4.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/upgrade-to/v4.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/upgrade-to/v4.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/upgrade-to/v4.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/upgrade-to/v4.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/upgrade-to/v4.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/upgrade-to/v4.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/upgrade-to/v4.mdx Outdated Show resolved Hide resolved
Copy link
Member Author

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review, Yan!

src/content/docs/en/guides/upgrade-to/v4.mdx Outdated Show resolved Hide resolved
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
@sarah11918 sarah11918 merged commit a5bd971 into main Dec 3, 2023
7 checks passed
@sarah11918 sarah11918 deleted the 4.0-upgrade-guide branch December 3, 2023 14:33
ematipico pushed a commit that referenced this pull request Jan 26, 2024
Co-authored-by: HiDeoo <HiDeoo@users.noreply.github.com>
Co-authored-by: Elian <hello@elian.codes>
Co-authored-by: Kevin Zuniga Cuellar <kevinzunigacuellar@users.noreply.github.com>
Co-authored-by: Atharva Pise <atharvapise19@gmail.com>
Co-authored-by: Paul Valladares <dreyfus92@users.noreply.github.com>
Co-authored-by: Reuben Tier <TheOtterlord@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Genteure <Genteure@users.noreply.github.com>
Co-authored-by: Kevin Zuniga Cuellar <46791833+kevinzunigacuellar@users.noreply.github.com>
Co-authored-by: Alex Nguyen <dev@alexnguyen.co.nz>
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.0 add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Astro 4.0 breaking changes tracker
7 participants