Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(ja): Update /guides/cms/contentful.mdx #5611

Merged

Conversation

kimulaco
Copy link
Contributor

@kimulaco kimulaco commented Dec 5, 2023

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 7, 2023 4:22pm

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Dec 5, 2023
Copy link
Contributor

@ryuapp ryuapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1点だけコメントさせて頂きました
お手すきの際にご確認ください

@@ -419,7 +425,7 @@ const { content, title, date } = Astro.props;
</html>
```

http://localhost:4321/posts/astro-is-amazing/にアクセスすると動的ルーティングが動作していることが分かります
http://localhost:4321/にアクセスしていずれかの投稿をクリックすると動的ルーティングが動作していることが分かります
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全部リンク化されていたので、スペースを空けると良いと思います
元の状態もリンク化されてましたね...

Suggested change
http://localhost:4321/にアクセスしていずれかの投稿をクリックすると動的ルーティングが動作していることが分かります!
http://localhost:4321/ にアクセスしていずれかの投稿をクリックすると動的ルーティングが動作していることが分かります!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。修正しました。 cb94661

Copy link
Contributor

@ryuapp ryuapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🎈🎈

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job peeps 🚀

@yanthomasdev yanthomasdev merged commit 2e81b6a into withastro:main Dec 7, 2023
6 checks passed
ematipico pushed a commit that referenced this pull request Jan 26, 2024
* i18n(ja): Update link hash of `/guides/cms/contentful.mdx`

* i18n(ja): Update contentful guide to reflect v10

* i18n(ja): Update pnpm command

* i18n(ja): Update to use FileTree component

* i18n(ja): Fix link

---------

Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants