Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goodbye, i18n Tracker! #5844

Merged
merged 4 commits into from Dec 19, 2023
Merged

Goodbye, i18n Tracker! #5844

merged 4 commits into from Dec 19, 2023

Conversation

yanthomasdev
Copy link
Member

Description (required)

Farewell, I18n Tracker 👋

Goku's iconic "Farewell, Buu" gif

Related issues & labels (optional)

  • Closes #
  • Suggested label:

Copy link

vercel bot commented Dec 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 19, 2023 8:25pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2023 8:25pm

@VoxelMC
Copy link
Contributor

VoxelMC commented Dec 19, 2023

o7

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢 🚢 🚢 🚢 🚢 🚢

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Yan-Thomas!

First off, what a headline stat 👀

Git diff summary showing one thousand and forty one lines deleted, seventeen lines added

Couple of questions:

  • Did you check if we could remove any other dependencies the old translation-status script relied on? (I noticed minimatch is removed.)
  • Were you able to test out the updated tuesday-bot script to check stuff like the new file loading etc. is working fine?

At a glance everything looks fine, but would love to hear about those!

@yanthomasdev
Copy link
Member Author

Were you able to test out the updated tuesday-bot script to check stuff like the new file loading etc. is working fine?

Yes, I modified the script a bit to just console.log locally and the message was output correctly with the same output for today.

Did you check if we could remove any other dependencies the old translation-status script relied on? (I noticed minimatch is removed.)

Yeah, simple-git and minimatch were the only ones. Other dependencies are used in the other scripts so I've kept them.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome — sounds perfect, thanks @Yan-Thomas!

This goodbye has my blessing 🫡 🥲 👋

@sarah11918
Copy link
Member

:houston_salute:

@hippotastic , thank you for your service!

@hippotastic
Copy link
Contributor

Happy to see the tracker live on and made available to a broader audience in Lunaria! :) Thank you @Yan-Thomas!

@yanthomasdev yanthomasdev merged commit cf3c143 into main Dec 19, 2023
8 checks passed
@yanthomasdev yanthomasdev deleted the goodbye-tracker branch December 19, 2023 20:26
ematipico pushed a commit that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants